Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(route53): Vpc endpoint service private dns #10780
feat(route53): Vpc endpoint service private dns #10780
Changes from 45 commits
446a54c
26f6998
702316c
af13454
7e8d2f1
4d7ec0f
4c617d5
8f40f10
1fc9648
5d9472d
bb7e875
3687738
578c851
426f771
46b4360
d6c31f1
30a654a
e260ffc
e948aab
684db32
3b026e8
4c294ba
da1d66e
e83aaa1
94a61dd
06c141b
b0b4e46
4f95f91
bf66346
ff00622
624a2d5
2094a72
8dd5d53
fdf8436
bc913f9
46e3645
e8c91fd
f2f6fa4
dd506ff
31d80c6
5a90d35
1e94c9b
31f5b10
c2a80f6
722a94e
09354d2
c99da4d
8d10ca2
b56d705
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a test that uses this property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, in ec2:
aws-cdk/packages/@aws-cdk/aws-ec2/test/integ.vpc-endpoint-service.ts
Lines 49 to 52 in 2b474b9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it an attribute of IVpcEndpointService because I would rather have it take an IVpcEndpointService as an argument, vs a VpcEndpointService
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I love this section. That's because I badly need it, I have no idea why you would care about this otherwise :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not just the same as an R53 Alias though? Guess I'm asking: why is it a different concept?
(Just for my understanding of the feature, nothing to do with the PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It kind of is a R53 alias, as if AWS was managing the hosted zone and ARecord for a service client.
For services exposed over a PrivateLink, a client has to set up the alias themselves -- create the hosted zone, ARecord, etc, because the service has no idea what the VPC endpoint DNS name is going to be (autogenerated on creation).
Private DNS basically means AWS will manage the DNS for the client, so the hostname will resolve correctly to the VPC endpoint without the client having to create a hosted zone or an ARecord.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be even better if we can import a hosted zone from different account by providing IAM access. DNS delegation may have been set up in a central account.