chore(release): 1.91.0 #13211
Merged
chore(release): 1.91.0 #13211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 9.1.0 to 9.1.1. - [Release notes](https://github.com/conventional-changelog/standard-version/releases) - [Changelog](https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md) - [Commits](conventional-changelog/standard-version@v9.1.0...v9.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.845.0 to 2.846.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.845.0...v2.846.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.8.46 to 0.8.47. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/master/CHANGELOG.md) - [Commits](evanw/esbuild@v0.8.46...v0.8.47) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
…3103) Give our creation role the necessary `ec2` permissions to allow creating clusters on environments without an existing SLR. The specific operations were taken from the managed policies of the SLRs. Comments inline. See #9027 (comment) for more context. Fixes #9027. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…13125) Based the fix on [`domainName` in `CertificateProps`](https://github.com/aws/aws-cdk/blob/33339e1c5f3ac280018e294c268c68929707dcce/packages/%40aws-cdk/aws-certificatemanager/lib/certificate.ts#L28-L28) (rendered version: https://docs.aws.amazon.com/cdk/api/latest/python/aws_cdk.aws_certificatemanager/CertificateProps.html#aws_cdk.aws_certificatemanager.CertificateProps.domain_name). Fixes #12287 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Use the result of a Docker build as code. The runtime code is expected to be located at `/asset` in the image. Also deprecate `BundlingDockerImage` in favor of `DockerImage`. Closes #11914 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.8.47 to 0.8.48. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/master/CHANGELOG.md) - [Commits](evanw/esbuild@v0.8.47...v0.8.48) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
* feat: cloudformation spec v28.0.0 * awslint execulde new attribute * remove new line Co-authored-by: AWS CDK Team <aws-cdk@amazon.com> Co-authored-by: NetaNir <neta1nir@gmail.com>
…on of a roadmap issue (#13136) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is the final part of the work started out in 200d52e. Most feature flags will be expired in CDKv2 and their 'enabled' behaviour made the default. To keep the divergence between the two branches (`master` and `v2-main`) to a minimum, update all integration tests to have the flags enabled. If the flag needs to be different for any specific test, it can be overridden when constructing the `App` object. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.846.0 to 2.847.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.846.0...v2.847.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 10.17.52 to 10.17.53. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.1.1 to 18.2.0. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](octokit/rest.js@v18.1.1...v18.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.8.48 to 0.8.49. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/master/CHANGELOG.md) - [Commits](evanw/esbuild@v0.8.48...v0.8.49) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
As we expire feature flags in CDKv2, remove the expired feature flags from the init templates. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
cloudformation-diff assumes the policies and statements it encounters are simple JSON objects. However, in reality, everywhere that simple object can be used, the Fn::If function can be used as well. Add code that handles that eventuality. Fixes #12887 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 10.17.53 to 10.17.54. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Customer reported incorrect argument to Values.projecting() in appsync README ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fixes: #12572 BREAKING CHANGE: graphqlapi.addRdsDataSource now takes databaseName as its fourth argument ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.847.0 to 2.848.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.847.0...v2.848.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Following #10200, our `KubectlProvider` functions are now provisioned inside a VPC when applicable. A somewhat unintended side effect is that the provider framework will **create** and use a dedicated security group for its functions. This can violate organizational policies that don't allow CDK to create security groups. We can easily avoid this by simply reusing the `kubectlSecurityGroup`, which must be defined in this case, and passing it to the provider. Fixes #12952 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Cleanup based on #13136 (comment). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…13182) Not sure how it got here, but if definitely doesn't belong. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.8.49 to 0.8.50. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/master/CHANGELOG.md) - [Commits](evanw/esbuild@v0.8.49...v0.8.50) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
CloudWatch Synthetics recently released new NodeJS runtimes (https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html). This PR is adding them and updating docs Fixes #12906 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
) * Revert to old behavior of allowing a data source to create a resolver as UNIT resolvers stem from data sources. * Maintaining new behavior of having `GraphqlApi` create resolvers as PIPELINE resolvers stem from the `GraphqlApi` itself Fixes #12635 Fixes #11522 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Automatic [PR](#13108) has merge conflicts, easier to create new PR. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We have a custom workflow called “yarn-upgrade” which takes care of continuously updating npm dependencies, so we decided to use Dependabot to only track non-npm dependencies. For this repository, this is basically just GitHub Actions. Replace the legacy `.dependabot/config.yml` with the native `.github/dependabot.yml` and configure it accordingly. Also, refactor the auto-approval workflows such that any PR with the `pr/auto-approve` label will get auto-approved by CDK automation. Utilize this new label to auto-approve dependency updates (both from our workflow and the Dependabot ones).
The PR #13047 introduced a corrupted dependabot config. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Bumps [actions/cache](https://github.com/actions/cache) from v2 to v2.1.4. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2...26968a0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Currently using single quotes truncates the documentation See screenshot belong: <img width="759" alt="Screen Shot 2021-02-19 at 7 15 31 AM" src="https://user-images.githubusercontent.com/5442469/108522984-4393b280-7282-11eb-8a55-c6853b4b09f5.png"> ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…12920) (Gave this change an eye-catching title so it would stand out in the change log) `cfn-lint` expects all stateful resources to have a removal policy, but we weren't providing that option at the L2 level yet, and the L1 API is cumbersome. Add the `removalPolicy` option to the following resources: * Cognito User Pools (default: RETAIN) * EC2 Volume (default: RETAIN) * ElasticSearch Domain (default: RETAIN) * FSx FileSystem (default: RETAIN) * SQS Queue (default: DESTROY) * Nested Stack (default: DESTROY) All L2 resources now have an `applyRemovalPolicy` method, so it can be set even for non-stateful resources. A mechanism has been added to the codegen so that new L2 authors cannot forget about the `removalPolicy` when they're writing an L2. I'm aware that the choice to make most of these RETAIN by default is going to be contentious. There are 2 questions here: * Is RETAIN the correct default in general? * Can we afford switching from implicit-DESTROY to implicit-RETAIN? ### Is RETAIN the correct default? I would argue "yes", by process of elimination: Defaulting `removalPolicy` for all resources to `DESTROY` if nothing is given (and writing `DESTROY` to the template) is just going to put us back to the situation in CloudFormation *before* `cfn-lint` existed (your stateful resources are going to be destroyed and nothing is going to warn you about it). Making `removalPolicy` explicitly required for all stateful resources is a backwards-breaking change, and the point about CDK is that it will have sane defaults. I can't come up with a better solution than picking RETAIN as default. ### Can we afford changing the default here? I'm sensitive to the arguments that this a breaking change which we can't afford. It feels like this is the value we would have given the resources had we thought about this earlier, and not being able to correct past mistakes by saying they are "locked in" is going to be a death knell for the project. We could go for a "future behavior" flag, but the risk here seems minimal: this is a change that REDUCES risk of data loss. It might increase risk of deployment errors (duplicate resource names), but that can be manually managed. I will fast-follow with a change that will introduce warnings for resources that have a physical name set and also a RETAIN policy, to clearly identify you're doing something dangerous in CloudFormation. I'm not sure it's worth the effort to go further than that. Although please: discussion welcome. Fixes #12563. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Resolves: #12567 BREAKING CHANGE: RdsDataSource now takes a ServerlessCluster instead of a DatabaseCluster ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Taking over the ownership of original PR #11738 feat(stepfunctions-tasks): support for EKS Call Implementation Update package @aws-cdk/aws-stepfunctions-tasks to include support for EKS Call API as per documentation here: https://docs.aws.amazon.com/step-functions/latest/dg/connect-eks.html Includes support for the following Amazon EKS API calls: eks:call ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Otherwise it is highly confusing or / and even wrong ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws-cdk-automation
added
the
pr/no-squash
|
|
njlynch
approved these changes
Feb 23, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CHANGELOG