fix(ssm): fix service principals for all regions since ap-east-1 #17047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jolo-dev
changed the title
peterwoodworth
changed the title
njlynch
previously requested changes
Oct 25, 2021
|
@njlynch Thanks for your review. I have apply your requests |
…-ap-east-1 # Conflicts: # version.v1.json
njlynch
previously approved these changes
Nov 5, 2021
njlynch
previously approved these changes
Nov 5, 2021
|
@njlynch I didn't know that you took over. I guess, you have to approve again. |
Can you please revert the changes to CHANGELOG.md? You've introduced merge conflicts here. You don't need to merge to the latest from |
|
Hey @njlynch, |
njlynch
approved these changes
Nov 11, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
added a commit
that referenced
this pull request
Oct 3, 2022
The change in #17047 was based on an eager reading of the documentation. The documentation referenced only applies to "SSM Inventory", not to "SSM Automation". And in fact there is no need for that change at all, since all accounts included in the regional service principal are also included in the global service principal. We therefore revert all use of SSM service principals to the global one.
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
…ons (#22327) The change in #17047 was based on an eager reading of the documentation. The documentation referenced only applies to "SSM Inventory", not to "SSM Automation". And in fact there is no need for that change at all, since all accounts included in the regional service principal are also included in the global service principal. We therefore revert all use of SSM service principals to the global one. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
arewa
pushed a commit
to arewa/aws-cdk
that referenced
this pull request
Oct 8, 2022
…ons (aws#22327) The change in aws#17047 was based on an eager reading of the documentation. The documentation referenced only applies to "SSM Inventory", not to "SSM Automation". And in fact there is no need for that change at all, since all accounts included in the regional service principal are also included in the global service principal. We therefore revert all use of SSM service principals to the global one. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16188
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license