Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssm): fix service principals for all regions since ap-east-1 #17047

Merged
merged 13 commits into from
Nov 11, 2021
Merged

fix(ssm): fix service principals for all regions since ap-east-1 #17047

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b9bed7e
Fix service principals for all regions since ap-east-1
jolo-dev Oct 18, 2021
34e4c76
Update Version to 1.128.0
jolo-dev Oct 19, 2021
68c483c
Merge branch 'master' into ssm-incorrect-since-ap-east-1
jolo-dev Oct 19, 2021
abc4acf
Simplifed case and test
jolo-dev Nov 5, 2021
6ed8af0
Undo version.v1.json changes
njlynch Nov 5, 2021
e67fb18
minor changes
njlynch Nov 5, 2021
883da11
reverting version change
njlynch Nov 5, 2021
47e8bc8
Merge remote-tracking branch 'origin/master' into ssm-incorrect-since…
njlynch Nov 5, 2021
c8674da
Resolve merge conflict
jolo-dev Nov 5, 2021
9780c23
Resolve merge conflict
jolo-dev Nov 5, 2021
73b031c
Revert Changelog
jolo-dev Nov 10, 2021
573feac
Merge branch 'master' into ssm-incorrect-since-ap-east-1
njlynch Nov 10, 2021
59f7580
Merge branch 'master' into ssm-incorrect-since-ap-east-1
mergify[bot] Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@aws-cdk/region-info/lib/default.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ export class Default {

// Services with a regional principal
case 'states':
case 'ssm':
return `${service}.${region}.amazonaws.com`;

// Services with a partitional principal
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/region-info/test/default.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const urlSuffix = '.nowhere.null';

describe('servicePrincipal', () => {
for (const suffix of ['', '.amazonaws.com', '.amazonaws.com.cn']) {
for (const service of ['states']) {
for (const service of ['states', 'ssm']) {
test(`${service}${suffix}`, () => {
expect(Default.servicePrincipal(`${service}${suffix}`, region, urlSuffix)).toBe(`${service}.${region}.amazonaws.com`);
});
Expand Down