-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): specifying --quiet does not suppress asset building and publishing logs #26265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Looks good! Can you sort out the build failure and add/extend a test to cover this new use case? There's an existing test but I'm not even sure it does test aws-cdk/packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts Line 725 in a523e9f
|
@Mergifyio update |
❌ Pull request can't be updated with latest base branch changesMergify needs the author permission to update the base branch of the pull request. |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
Closed in favor of #26493 |
…lishing logs (#26493) > We're currently maintaining a patched version of CDK to use with [SST](https://docs.sst.dev/) because this flag isn't fully respected. When the quiet flag is specified, the docker build and docker push shell commands still print to the terminal. This PR propagates the quiet flag down to the cdk-assets's container-images handler. Replaces #26265 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We're currently maintaining a patched version of CDK to use with SST because this flag isn't fully respected. When the
quiet
flag is specified, thedocker build
anddocker push
shell commands still print to the terminal. This PR propagates thequiet
flag down to thecdk-assets
'scontainer-images
handler.Would appreciate this functionality - would greatly simplify things on our end
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license