Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): specifying --quiet does not suppress asset building and publishing logs #26493

Merged
merged 4 commits into from
Aug 3, 2023
Merged

fix(cli): specifying --quiet does not suppress asset building and publishing logs #26493

merged 4 commits into from
Aug 3, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jul 25, 2023

We're currently maintaining a patched version of CDK to use with SST because this flag isn't fully respected. When the quiet flag is specified, the docker build and docker push shell commands still print to the terminal. This PR propagates the quiet flag down to the cdk-assets's container-images handler.

Replaces #26265

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 25, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 25, 2023 11:44
@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed p2 labels Jul 25, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 25, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jul 25, 2023
@mrgrain
Copy link
Contributor Author

mrgrain commented Jul 25, 2023

Execution ID: 8103dfc8-c9a9-4c46-8122-03563d371526

@mrgrain mrgrain removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jul 25, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jul 25, 2023
@mrgrain mrgrain removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jul 25, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jul 25, 2023
@mrgrain mrgrain added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Jul 25, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 25, 2023 13:37

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 25, 2023
@kaizencc kaizencc changed the title fix(cli): specifying --quiet does not suppress asset building and puplishing logs fix(cli): specifying --quiet does not suppress asset building and publishing logs Jul 25, 2023
@github-actions github-actions bot added the p2 label Jul 25, 2023
@mrgrain mrgrain force-pushed the mrgrain/fix/cli-quiet-is-not-quiet branch from 4aec5cd to a6d2481 Compare July 26, 2023 15:28
@mrgrain mrgrain temporarily deployed to test-pipeline July 26, 2023 23:56 — with GitHub Actions Inactive
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

kaizencc
kaizencc reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making a dummy review to test the trigger workflow -- your build is failing!

kaizencc
kaizencc reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another test review, dont mind me

@mrgrain mrgrain mentioned this pull request Jul 28, 2023
Closed
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7326308
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b12bc67 into main Aug 3, 2023
7 of 8 checks passed
@mergify mergify bot deleted the mrgrain/fix/cli-quiet-is-not-quiet branch August 3, 2023 13:57
@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@fwang
Copy link

fwang commented Aug 13, 2023

Thanks for getting this one in @mrgrain! I owe you a ☕️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc left review comments

@rix0rrr rix0rrr rix0rrr approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrgrain @aws-cdk-automation @fwang @rix0rrr @kaizencc