Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cognito): support emailVerified attribute mapping #30482

Closed
wants to merge 5 commits into from
Closed

feat(cognito): support emailVerified attribute mapping #30482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc8e6d4
chore(cognito): exposed email_verified attribute
mirkods Jun 7, 2024
8fdcc3b
fix(cognito): alined test convention for files
mirkods Jun 7, 2024
4472907
fix: restored file name
mirkods Jun 7, 2024
ea46cb1
test: added integration tests
mirkods Jun 10, 2024
792a8df
fix: restored original indentation
mirkods Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@aws-cdk-testing/framework-integ/test/aws-cognito/test/integ.user-pool-idp.oidc.ts
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update the related snapshots file as well (here and here). Otherwise, the build will keep failing.

Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ new UserPoolIdentityProviderOidc(stack, 'cdk', {
scopes: ['openid', 'phone'],
attributeMapping: {
phoneNumber: ProviderAttribute.other('phone_number'),
emailVerified: ProviderAttribute.other('email_verified'),
},
});

Expand Down
6 changes: 6 additions & 0 deletions packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ export interface AttributeMapping {
*/
readonly email?: ProviderAttribute;

/**
* The user's e-mail address is verification.
* @default - not mapped
*/
readonly emailVerified?: ProviderAttribute;

/**
* The surname or last name of user.
* @default - not mapped
Expand Down
2 changes: 2 additions & 0 deletions packages/aws-cdk-lib/aws-cognito/test/user-pool-idps/base.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,15 @@ describe('UserPoolIdentityProvider', () => {
attributeMapping: {
givenName: ProviderAttribute.FACEBOOK_NAME,
birthdate: ProviderAttribute.FACEBOOK_BIRTHDAY,
emailVerified: ProviderAttribute.other('email_verified'),
},
});

// THEN
expect(idp.mapping).toStrictEqual({
given_name: 'name',
birthdate: 'birthday',
email_verified: 'email_verified',
});
});

Expand Down
Loading