feat(ecs-patterns): add containerCpu and containerMemoryLimitMiB property to ApplicationLoadBalancedFargateService

[ren-yamanashi]

Issue #20638

Closes #20638

Reason for this change

ApplicationLoadBalancedFargateService did not allow you to specify the CPU and memory of the container.

Description of changes

• Add containerCpu property to ApplicationLoadBalancedFargateServiceProps
• Add containerMemoryLimitMiB property to ApplicationLoadBalancedFargateServiceProps

Description of how you validated changes

Added both unit and integration tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[go-to-k]

Could you change the PR title from "feat(application-load-balanced-fargate-service): ..." to "feat(ecs-patterns): add containerCpu and containerMemoryLimitMiB property to ApplicationLoadBalancedFargateService"? Because we should specify the module name, not the construct name.

[ren-yamanashi]

@go-to-k

Could you change the PR title from "feat(application-load-balanced-fargate-service): ..." to "feat(ecs-patterns): add containerCpu and containerMemoryLimitMiB property to ApplicationLoadBalancedFargateService"? Because we should specify the module name, not the construct name.

Thank you for the suggestion. I have updated the PR title. Please check the changes at your convenience.

[go-to-k]

Thanks for this PR! I made some comments.

[ren-yamanashi]

@go-to-k

Thanks for the review! We have fixed it, so please check it out!

(A link to the fix commit is provided in reply to the thread.)

[go-to-k]

If the containerCpu and the containerMemoryLimitMiB are larger than (or equal to) the cpu and the memoryLimitMiB, will CloudFormation deploy errors occur?
If so, it is good to add validations for them. (and also good to add corresponding unit tests)

for example:

      if (
        props.containerCpu &&
        !Token.isUnresolved(props.containerCpu) &&
        props.cpu &&
        !Token.isUnresolved(props.cpu) &&
        props.containerCpu > props.cpu // or `props.containerCpu >= props.cpu`
      ) {
        throw new Error('containerCpu must be less than or equal to cpu');
      }
      // The same applies to memory.
      // ...

see: https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ecs-patterns/lib/fargate/application-load-balanced-fargate-service.ts#L108-L119

As with the validateHealthyPercentage method, it may also be possible to check for values that are not negative. (If CFn fails for negative values.)

[go-to-k]

This is a dummy comment for labeling tests.

[go-to-k]

I approved it, so it should have a pr/needs-maintainer-review label, but apparently it doesn't. Could you try to pull diffs from the main branch?

The result in the PR Linter / validate-pr action is apparently that CodeBuild is not successful. (see: https://github.com/aws/aws-cdk/tree/v2.155.0/tools/@aws-cdk/prlint/lint.ts#L587)

Run ./tools/@aws-cdk/prlint
  env:
    GITHUB_TOKEN: ***
    PR_NUMBER: 
    PR_SHA: 
    REPO_ROOT: /home/runner/work/aws-cdk/aws-cdk
⌛  Fetching PR number 309[2](https://github.com/aws/aws-cdk/actions/runs/10625116391/job/29454561862?pr=30920#step:4:2)0
⌛  Fetching files for PR number [3](https://github.com/aws/aws-cdk/actions/runs/10625116391/job/29454561862?pr=30920#step:4:3)0920
⌛  Validating...
Deleting PR Linter Comment now
✅  Success
CodeBuild Commit Statuses:  []
PR code build job not yet successful

Could you try making some changes to the description of this PR first? (This is because the job will be run again if the PR is edited.)

If there are still no changes in labels, could you try running CodeBuild CI again?

[ren-yamanashi]

@go-to-k

PR Linter / validate-pr succeeded!

Run ./tools/@aws-cdk/prlint
  env:
    GITHUB_TOKEN: ***
    PR_NUMBER: 
    PR_SHA: 
    REPO_ROOT: /home/runner/work/aws-cdk/aws-cdk
⌛  Fetching PR number 30920
⌛  Fetching files for PR number 30920
⌛  Validating...
Deleting PR Linter Comment now
✅  Success
CodeBuild Commit Statuses:  [ 'success', 'pending' ]
PR code build job SUCCESSFUL

Regarding the label change, it seems that it has not been approved, so could you please approve?

If the label is still not granted, I will try runnning PR Linter or CodeBuild CI again.

[go-to-k]

I approved, but the PR doesn't have the label.

Could you run PR Linter again?

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 87b5f49
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[go-to-k]

Could you try making some changes to the description of this PR without running CodeBuild CI?

[ren-yamanashi]

@go-to-k

I ran PR Linter without runnning CodeBuild again, but the PR doesn't have the label...
Looking at other PRs, it was labeled successfully, but is there a problem with what I submitted?

[go-to-k]

It appears that the status is CHANGES_REQUESTED and the communityApproved is false even though it has been approved: https://github.com/aws/aws-cdk/actions/runs/10669155243/job/29570426536

raw data: 
{
  "go-to-k": {
    "id": 2225629631,
    "node_id": "PRR_kwDOBk6Df86EqGm_",
    "user": {
      "login": "go-to-k",
      "id": 24818752,
      "node_id": "MDQ6VXNlcjI0ODE4NzUy",
      "avatar_url": "https://avatars.githubusercontent.com/u/24818752?u=e284689a061d1e9378ffd7b4e76bdc5320bfc45a&v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/go-to-k",
      "html_url": "https://github.com/go-to-k",
      "followers_url": "https://api.github.com/users/go-to-k/followers",
      "following_url": "[https://api.github.com/users/go-to-k/following{/other_user}](https://api.github.com/users/go-to-k/following%7B/other_user%7D)",
      "gists_url": "[https://api.github.com/users/go-to-k/gists{/gist_id}](https://api.github.com/users/go-to-k/gists%7B/gist_id%7D)",
      "starred_url": "[https://api.github.com/users/go-to-k/starred{/owner}{/repo}](https://api.github.com/users/go-to-k/starred%7B/owner%7D%7B/repo%7D)",
      "subscriptions_url": "https://api.github.com/users/go-to-k/subscriptions",
      "organizations_url": "https://api.github.com/users/go-to-k/orgs",
      "repos_url": "https://api.github.com/users/go-to-k/repos",
      "events_url": "[https://api.github.com/users/go-to-k/events{/privacy}](https://api.github.com/users/go-to-k/events%7B/privacy%7D)",
      "received_events_url": "https://api.github.com/users/go-to-k/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "state": "CHANGES_REQUESTED",
    "html_url": "https://github.com/aws/aws-cdk/pull/30920#pullrequestreview-2225629631",
    "pull_request_url": "https://api.github.com/repos/aws/aws-cdk/pulls/30920",
    "author_association": "CONTRIBUTOR",
    "_links": {
      "html": {
        "href": "https://github.com/aws/aws-cdk/pull/30920#pullrequestreview-2225629631"
      },
      "pull_request": {
        "href": "https://api.github.com/repos/aws/aws-cdk/pulls/30920"
      }
    },
    "submitted_at": "2024-08-07T16:14:56Z",
    "commit_id": "ef494bd1fe8f15fcb4d5d60e4b804cdfc8123366"
  }
}

evaluation:  {
  "draft": false,
  "mergeable_state": "blocked",
  "maintainerRequestedChanges": false,
  "maintainerApproved": false,
  "communityRequestedChanges": true,
  "communityApproved": false,
  "userRequestsExemption": false
}

Apparently there was too much history to get all the latest data.

https://github.com/aws/aws-cdk/blob/main/tools/@aws-cdk/prlint/lint.ts#L376

  private async assessNeedsReview(
    pr: Pick<GitHubPr, 'mergeable_state' | 'draft' | 'labels' | 'number'>,
  ): Promise<void> {
    const reviews = await this.client.pulls.listReviews(this.prParams);
    console.log(JSON.stringify(reviews.data));

I will consult with the CDK team.

P.S. I will take the problem in the PR: #31290

[ren-yamanashi]

Thank you very much!

[go-to-k]

@ren-yamanashi

Hi, the fix PR has been merged!

#31290

I approved it again and the review label was successfully attached.

[ren-yamanashi]

Thank you for your quick response!