Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update message in GHA lock conversations #30942

Merged
merged 2 commits into from
Jul 24, 2024
Merged

chore: update message in GHA lock conversations #30942

merged 2 commits into from
Jul 24, 2024

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Jul 24, 2024

Issue # (if applicable)

Fix the misleading message in #30941

Reason for this change

Update message left by GHA

Description of changes

Since we lock conversations, we should update the message to be more accurate.

Description of how you validated changes

Tested in private fork with GHA.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@GavinZZ GavinZZ changed the title Update message in GHA lock conversations chore: update message in GHA lock conversations Jul 24, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 24, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team July 24, 2024 20:59
@github-actions github-actions bot added the p2 label Jul 24, 2024
Copy link
Contributor

mergify bot commented Jul 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@GavinZZ GavinZZ marked this pull request as ready for review July 24, 2024 21:45
@GavinZZ
Copy link
Contributor Author

GavinZZ commented Jul 24, 2024

@mergify update

Copy link
Contributor

mergify bot commented Jul 24, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f01efe4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit cd80fca into main Jul 24, 2024
11 of 12 checks passed
Copy link
Contributor

mergify bot commented Jul 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the lock_fix branch July 24, 2024 22:15
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
@GavinZZ GavinZZ added p1 and removed p2 labels Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants