[customizations/eks]: Update credential API version #6289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahhausler
force-pushed
the
eks-get-token-update
branch
from
a8b50d8 to
2378426
Compare
nckturner
approved these changes
Jul 22, 2021
Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes v1.11 (kubernetes/kubernetes#64482), and EKS currently supports Kubernetes versions v1.16 through v1.21. This is a breaking change for clients running versions v1.10 and older, which haven't been supported by EKS since September 2019. Signed-off-by: Micah Hausler <mhausler@amazon.com>
micahhausler
force-pushed
the
eks-get-token-update
branch
from
2378426 to
3569d49
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6289 +/- ##
========================================
Coverage 92.81% 92.81%
========================================
Files 204 204
Lines 16201 16201
========================================
Hits 15037 15037
Misses 1164 1164
Continue to review full report at Codecov.
|
|
When will these changes be included in v2 (sorry I'm unfamiliar with the workflow here)? |
|
@stevehipwell , it's in 2.2.24. |
|
I think there might have been a lack of communication around this change? |
2 tasks
kdaily
added
customization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes has deprecated v1alpha1, v1beta1 has been available since Kubernetes
v1.11 (kubernetes/kubernetes#64482), and EKS currently supports Kubernetes
versions v1.16 through v1.21. This is a breaking change for clients running
versions v1.10 and older, which haven't been supported by EKS since September
2019.
Signed-off-by: Micah Hausler mhausler@amazon.com
Issue #, if available:
N/A
Description of changes:
Update Kubernetes client authentication API version.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.