Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update credential api version to v1alpha1 for eks #328

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Update credential api version to v1alpha1 for eks #328

merged 1 commit into from
Aug 12, 2021

Conversation

tei-k
Copy link
Contributor

@tei-k tei-k commented Aug 5, 2021

Description

https://scalar-labs.atlassian.net/browse/DLT-9641

Unable to connect to the server: getting credentials: exec plugin is configured to use API version client.authentication.k8s.io/v1beta1, plugin returned version client.authentication.k8s.io/v1alpha1

refs:

Done

  • Update api version to v1alpha1

@tei-k tei-k added the bugfix label Aug 5, 2021
@tei-k tei-k self-assigned this Aug 5, 2021
@tei-k tei-k requested review from feeblefakie and ymorimo August 5, 2021 06:04
ymorimo
ymorimo approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@ymorimo ymorimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

feeblefakie
feeblefakie reviewed Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't really get the reason for the change.
Can you clarify why we need this change?
Also, do we need to downgrade to alpha?

@tei-k
Copy link
Contributor Author

tei-k commented Aug 12, 2021

@feeblefakie

Can you clarify why we need this change?

Also, do we need to downgrade to alpha?

Yes, Because still using v1alpha1 in the current latest version.
https://github.com/aws/aws-cli/blob/8fa65cd54827c8b0f7e32afd9f79c8836654ccba/awscli/customizations/eks/get_token.py#L77

feeblefakie
feeblefakie approved these changes Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 34ba6f7 into master Aug 12, 2021
@feeblefakie feeblefakie deleted the update-credential-api-version-to-v1alpha1-for-eks branch August 12, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@ymorimo ymorimo ymorimo approved these changes

Assignees

@tei-k tei-k

Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tei-k @ymorimo @feeblefakie