Fix: Support JVM version string from old (< v8.9) and new (>= v8.9) gradle version #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/external
stage/needs-triage
jeffryang24
changed the title
hnnasit
reviewed
Sep 12, 2024
| @@ -83,5 +83,5 @@ def _get_jvm_string(self, gradle_path): | |||
|
|
|||
| for line in stdout.splitlines(): | |||
| l_dec = decode(line) | |||
| if l_dec.startswith("JVM"): | |||
| if l_dec.startswith("JVM") or l_dec.startswith("Launcher JVM"): | |||
There was a problem hiding this comment.
nit: This could be simplified to l_dec.contains("JVM")
There was a problem hiding this comment.
I see, I will change it with .contains(...) alike method, probably use x in y style. 👍
There was a problem hiding this comment.
Updated with in operator to check the JVM substring.
There was a problem hiding this comment.
Hi @hnnasit , is there something that I need to do so this PR can be merged? Thank you 🙇
There was a problem hiding this comment.
Hey @jeffryang24, our CI checks are failing consistently (and randomly out of the blue). The failures are unrelated to your changes, but we're working on fixing them. At the moment, there is no action needed from your side. Thanks for waiting
hnnasit
approved these changes
Sep 12, 2024
mndeveci
approved these changes
Nov 15, 2024
jeffryang24
deleted the
fix/support-old-and-new-gradle-jvm-version-label
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: This PR should resolve #682
Description of changes:
JVMandLauncher JVMprefix for thegradle[w] -versioncommand output. Gradle < v8.9 was usingJVM: x.x.x, while Gradle >= v8.9 has changed it toLauncher JVM: x.x.x.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.