[develop] Throw specific Exception instead of generic one #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeseawalker
force-pushed
the
wip/fixB017
branch
2 times, most recently
from
38c7445
to
ff67b7b
Compare
lukeseawalker
force-pushed
the
wip/fixB017
branch
from
ff67b7b
to
6afe2df
Compare
lukeseawalker
changed the title
lukeseawalker
force-pushed
the
wip/fixB017
branch
6 times, most recently
from
7a27c6c
to
1c7d7d9
Compare
lukeseawalker
changed the title
lukeseawalker
force-pushed
the
wip/fixB017
branch
6 times, most recently
from
2109973
to
f81ec20
Compare
This to solve check flake8 B017 Also disable B028 flake8-bugbear lint check recently implemented. The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333 Fix color formatting on flake8 style offenses. Signed-off-by: Luca Carrogu <carrogu@amazon.com>
lukeseawalker
force-pushed
the
wip/fixB017
branch
from
f81ec20
to
77b545a
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luca Carrogu carrogu@amazon.com
Description of changes
Throw specific Exception instead of generic one
This to solve check flake8 B017
Also disable B028 flake8-bugbear lint check recently implemented.
The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333
Fix color formatting on flake8 style offenses.
Tests
unit tested
References
n/a
Checklist
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.