Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename B028 to B907, making it optional/opinionated. #333

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Rename B028 to B907, making it optional/opinionated. #333

merged 1 commit into from
Jan 18, 2023

Conversation

jakkdl
Copy link
Contributor

@jakkdl jakkdl commented Jan 16, 2023

Fixes #329
Fixes #331
Fixes #332

For a certain definition of "fixes" at least, the check could perhaps be improved to make it less opinionated and more useful, but silencing lots of unnecessary warnings is the first step regardless.

@jdeamicis jdeamicis mentioned this pull request Jan 16, 2023
Merged
4 tasks
jdeamicis added a commit to jdeamicis/aws-parallelcluster-node that referenced this pull request Jan 16, 2023
@jdeamicis
Disable B028 flake8-bugbear lint check
2932c13 
The B028 check is going to be made optional/opinionated in
flake8-bugbear. See PyCQA/flake8-bugbear#333

Fix color formatting on flake8 style offenses.

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
jdeamicis added a commit to jdeamicis/aws-parallelcluster-cookbook that referenced this pull request Jan 16, 2023
@jdeamicis
Disable B028 flake8-bugbear lint check
44397b0 
The B028 check is going to be made optional/opinionated in
flake8-bugbear. See PyCQA/flake8-bugbear#333

Fix color formatting on flake8 style offenses.

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
jdeamicis added a commit to jdeamicis/aws-parallelcluster that referenced this pull request Jan 16, 2023
@jdeamicis
Disable B028 flake8-bugbear lint check
4b688f6 
The B028 check is going to be made optional/opinionated in
flake8-bugbear. See PyCQA/flake8-bugbear#333

Fix color formatting on flake8 style offenses.

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
This was referenced Jan 16, 2023
Closed
Merged
KerberosMorphy
KerberosMorphy reviewed Jan 16, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@charliermarsh charliermarsh mentioned this pull request Jan 16, 2023
Closed
cooperlees
cooperlees requested changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. This is one I'm 50/50 on too. Please fix the README and I'll merge and ship asap.

README.rst Outdated Show resolved Hide resolved
@wookie184 wookie184 mentioned this pull request Jan 16, 2023
Closed
@matthiasdiener matthiasdiener mentioned this pull request Jan 17, 2023
Merged
8 tasks
lukeseawalker added a commit to lukeseawalker/aws-parallelcluster-cookbook that referenced this pull request Jan 17, 2023
@lukeseawalker
Throw specific Exception instead of generic one
2109973 
This to solve check flake8 B017

Also disable B028 flake8-bugbear lint check recently implemented.
The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333

Signed-off-by: Luca Carrogu <carrogu@amazon.com>
@lukeseawalker lukeseawalker mentioned this pull request Jan 17, 2023
Merged
4 tasks
lukeseawalker added a commit to lukeseawalker/aws-parallelcluster-cookbook that referenced this pull request Jan 17, 2023
@lukeseawalker
Throw specific Exception instead of generic one
f81ec20 
This to solve check flake8 B017

Also disable B028 flake8-bugbear lint check recently implemented.
The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333

Signed-off-by: Luca Carrogu <carrogu@amazon.com>
lukeseawalker added a commit to lukeseawalker/aws-parallelcluster-cookbook that referenced this pull request Jan 17, 2023
@lukeseawalker
Throw specific Exception instead of generic one
77b545a 
This to solve check flake8 B017

Also disable B028 flake8-bugbear lint check recently implemented.
The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333

Fix color formatting on flake8 style offenses.

Signed-off-by: Luca Carrogu <carrogu@amazon.com>
francesco-giordano pushed a commit to aws/aws-parallelcluster-cookbook that referenced this pull request Jan 17, 2023
@lukeseawalker @francesco-giordano
Throw specific Exception instead of generic one
1e277d4 
This to solve check flake8 B017

Also disable B028 flake8-bugbear lint check recently implemented.
The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333

Fix color formatting on flake8 style offenses.

Signed-off-by: Luca Carrogu <carrogu@amazon.com>
@chrispap95 chrispap95 mentioned this pull request Jan 17, 2023
Closed
@jakkdl
Copy link
Contributor Author

jakkdl commented Jan 17, 2023

Fixed the location, so you can ship it straight away.

@danlamanna danlamanna mentioned this pull request Jan 17, 2023
Closed
@matthiasdiener matthiasdiener mentioned this pull request Jan 17, 2023
Closed
8 tasks
@davidism davidism mentioned this pull request Jan 17, 2023
Merged
cooperlees
cooperlees approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks! Seems popular people want this.

@cooperlees cooperlees merged commit 91188aa into PyCQA:main Jan 18, 2023
jdeamicis added a commit to jdeamicis/aws-parallelcluster that referenced this pull request Jan 18, 2023
@jdeamicis
Disable B028 flake8-bugbear lint check
122029f 
The B028 check is going to be made optional/opinionated in
flake8-bugbear. See PyCQA/flake8-bugbear#333

Fix color formatting on flake8 style offenses.

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
jdeamicis added a commit to aws/aws-parallelcluster that referenced this pull request Jan 18, 2023
@jdeamicis
Disable B028 flake8-bugbear lint check (#4798)
bbfab7e 
The B028 check is going to be made optional/opinionated in
flake8-bugbear. See PyCQA/flake8-bugbear#333

Fix color formatting on flake8 style offenses.

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
jdeamicis added a commit to jdeamicis/aws-parallelcluster-node that referenced this pull request Feb 1, 2023
@jdeamicis
Disable B028 flake8-bugbear lint check
50fd90c 
The B028 check is going to be made optional/opinionated in
flake8-bugbear. See PyCQA/flake8-bugbear#333

Fix color formatting on flake8 style offenses.

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
enrico-usai pushed a commit to enrico-usai/aws-parallelcluster-cookbook that referenced this pull request Feb 2, 2023
@lukeseawalker @enrico-usai
Throw specific Exception instead of generic one
cd0583a 
This to solve check flake8 B017

Also disable B028 flake8-bugbear lint check recently implemented.
The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333

Fix color formatting on flake8 style offenses.

Signed-off-by: Luca Carrogu <carrogu@amazon.com>
tobiasjj added a commit to lumicks/pylake that referenced this pull request May 8, 2023
@tobiasjj
flake8: B09 got renamed to B907. See PyCQA/flake8-bugbear#333
93b9cb1
tobiasjj added a commit to lumicks/pylake that referenced this pull request May 8, 2023
@tobiasjj
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
e47944e
@tobiasjj tobiasjj mentioned this pull request May 10, 2023
Open
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Aug 4, 2023
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
d6e62fe
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Aug 4, 2023
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
7accae6
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Aug 7, 2023
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
6d8ff8c
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Aug 8, 2023
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
8e41a34
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Aug 8, 2023
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
585d37c
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Aug 11, 2023
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
62d99a2
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Aug 14, 2023
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
0c01059
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Aug 15, 2023
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
5d50735
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Mar 4, 2024
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
ef802f4
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Mar 4, 2024
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
cc6a744
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Mar 4, 2024
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
69057f3
JoepVanlier pushed a commit to lumicks/pylake that referenced this pull request Mar 11, 2024
@tobiasjj @JoepVanlier
flake8: B028 got renamed to B907. See PyCQA/flake8-bugbear#333
d07c9eb
@alexcdennis alexcdennis mentioned this pull request Jun 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerberosMorphy KerberosMorphy KerberosMorphy left review comments

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jakkdl @cooperlees @KerberosMorphy