Skip to content

Commit

Permalink
Disable B028 flake8-bugbear lint check (#4798)
Browse files Browse the repository at this point in the history
The B028 check is going to be made optional/opinionated in
flake8-bugbear. See PyCQA/flake8-bugbear#333

Fix color formatting on flake8 style offenses.

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
  • Loading branch information
jdeamicis committed Jan 18, 2023
1 parent 8647550 commit bbfab7e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
7 changes: 5 additions & 2 deletions awsbatch-cli/.flake8
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ ignore =
# D413: Missing blank line after last section
D413,
# F821: undefined name
F821
F821,
# B028: Consider replacing f"'{foo}'" with f"{foo!r}".
# Currently being disabled by flake8-bugbear. See https://github.com/PyCQA/flake8-bugbear/pull/333
B028
# D101 Missing docstring in public class
# D102 Missing docstring in public method
per-file-ignores =
Expand All @@ -36,4 +39,4 @@ max-complexity = 10
max-line-length = 120
import-order-style = google
application-import-names = flake8
format = ${cyan}%(path)s${reset}:${yellow_bold}%(row)d${reset}:${green_bold}%(col)d${reset}: ${red_bold}%(code)s${reset} %(text)s
format = %(cyan)s%(path)s%(reset)s:%(bold)s%(yellow)s%(row)d%(reset)s:%(bold)s%(green)s%(col)d%(reset)s: %(bold)s%(red)s%(code)s%(reset)s %(text)s
7 changes: 5 additions & 2 deletions cli/.flake8
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ ignore =
# F821: undefined name
F821,
# N818: exception name should be named with an Error suffix
N818
N818,
# B028: Consider replacing f"'{foo}'" with f"{foo!r}".
# Currently being disabled by flake8-bugbear. See https://github.com/PyCQA/flake8-bugbear/pull/333
B028
# D101 Missing docstring in public class
# D102 Missing docstring in public method
# D202 No blank lines allowed after function docstring
Expand Down Expand Up @@ -47,4 +50,4 @@ max-complexity = 10
max-line-length = 120
import-order-style = google
application-import-names = flake8
format = ${cyan}%(path)s${reset}:${yellow_bold}%(row)d${reset}:${green_bold}%(col)d${reset}: ${red_bold}%(code)s${reset} %(text)s
format = %(cyan)s%(path)s%(reset)s:%(bold)s%(yellow)s%(row)d%(reset)s:%(bold)s%(green)s%(col)d%(reset)s: %(bold)s%(red)s%(code)s%(reset)s %(text)s

0 comments on commit bbfab7e

Please sign in to comment.