Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Exclude dotnet8 runtimes for Docker related tests #6747

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

lucashuy
Copy link
Contributor

@lucashuy lucashuy commented Feb 26, 2024

Which issue(s) does this change fix?

N/A

Why is this change necessary?

The canary environment runs some of the tests do not support running AL2023 in an older Docker environment.

How does it address the issue?

Exclude only those tests from being run when a Docker container is required.

What side effects does this change have?

None.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucashuy lucashuy marked this pull request as ready for review February 29, 2024 17:08
@lucashuy lucashuy requested a review from a team as a code owner February 29, 2024 17:08
@lucashuy lucashuy requested review from hnnasit and sidhujus February 29, 2024 17:08
@lucashuy lucashuy enabled auto-merge March 1, 2024 00:18
@lucashuy lucashuy added this pull request to the merge queue Mar 1, 2024
Merged via the queue into develop with commit 613b12d Mar 1, 2024
55 checks passed
@lucashuy lucashuy deleted the exclude_dotnet8_windows branch May 16, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants