Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Exclude dotnet8 runtimes for Docker related tests #6747

Merged
merged 2 commits into from
Mar 1, 2024
Merged

fix(tests): Exclude dotnet8 runtimes for Docker related tests #6747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69d3f54
Exclude dotnet8 runtimes for Docker related tests
lucashuy Feb 26, 2024
0d3cf6b
Merge branch 'develop' into exclude_dotnet8_windows
lucashuy Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/integration/buildcmd/test_build_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ def test_with_default_requirements(self, runtime, use_container):
]
)
def test_with_dockerfile_extension(self, runtime, use_container):
if not runtime_supported_by_docker(f"python{runtime}") and IS_WINDOWS:
self.skipTest(RUNTIME_NOT_SUPPORTED_BY_DOCKER_MSG)

_tag = uuid4().hex
overrides = {
"Runtime": runtime,
Expand Down Expand Up @@ -1230,6 +1233,9 @@ def test_dotnet_in_process(self, runtime, code_uri, mode, architecture="x86_64")
command_result = run_command(cmdlist, cwd=self.working_dir, env=newenv)
self.assertEqual(command_result.process.returncode, 0)

if not runtime_supported_by_docker(runtime) and IS_WINDOWS:
self.skipTest(RUNTIME_NOT_SUPPORTED_BY_DOCKER_MSG)

self._verify_built_artifact(
self.default_build_dir,
self.FUNCTION_LOGICAL_ID,
Expand Down Expand Up @@ -1280,6 +1286,9 @@ def test_dotnet_in_process(self, runtime, code_uri, mode, architecture="x86_64")
)
@skipIf(SKIP_DOCKER_TESTS or SKIP_DOCKER_BUILD, SKIP_DOCKER_MESSAGE)
def test_dotnet_in_container_mount_with_write_explicit(self, runtime, code_uri, mode, architecture="x86_64"):
if not runtime_supported_by_docker(runtime) and IS_WINDOWS:
self.skipTest(RUNTIME_NOT_SUPPORTED_BY_DOCKER_MSG)

overrides = {
"Runtime": runtime,
"CodeUri": code_uri,
Expand Down Expand Up @@ -1360,6 +1369,9 @@ def test_dotnet_in_container_mount_with_write_interactive(
mode,
architecture="x86_64",
):
if not runtime_supported_by_docker(runtime) and IS_WINDOWS:
self.skipTest(RUNTIME_NOT_SUPPORTED_BY_DOCKER_MSG)

overrides = {
"Runtime": runtime,
"CodeUri": code_uri,
Expand Down
Loading