Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fuzzing tests are not run in CI and are invalid. #1693

Closed
aryan9600 opened this issue Apr 30, 2022 · 4 comments · Fixed by #1710
Closed

Fuzzing tests are not run in CI and are invalid. #1693

aryan9600 opened this issue Apr 30, 2022 · 4 comments · Fixed by #1710
Labels
bug This issue is a bug.

Comments

@aryan9600
Copy link

aryan9600 commented Apr 30, 2022 •
edited
Loading

Describe the bug

The internal/ini package has a fuzz test, which is invalid. It tests the Parse function in internal/ini/ini.go, but it calls the function incorrectly, not providing the second argument.
Due to the fact that tests in CI aren't failing, and internal/ini/go.mod is missing https://github.com/dvyukov/go-fuzz, I don't think the test is being actually run in CI.

Expected Behavior

Fuzzing tests are valid and are executed in CI.

Current Behavior

Fuzzing tests are invalid and are not executed in CI.

Reproduction Steps

We have fuzzing tests for our project, which threw an error because of this, ref: https://github.com/fluxcd/kustomize-controller/runs/6239372370?check_suite_focus=true

Possible Solution

No response

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

github.com/aws/aws-sdk-go-v2 v1.16.3
github.com/aws/aws-sdk-go-v2/config v1.15.4
github.com/aws/aws-sdk-go-v2/credentials v1.12.0
github.com/aws/aws-sdk-go-v2/service/kms v1.17.1
github.com/aws/aws-sdk-go-v2/service/sts v1.16.4

Compiler and Version used

1.17

Operating System and version

Linux
@aryan9600 aryan9600 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 30, 2022
@aryan9600 aryan9600 mentioned this issue Apr 30, 2022
Merged
@jasdel
Copy link
Contributor

jasdel commented May 5, 2022

Thanks for reaching out to us. We have draft PR #1291 that is in our backlog to correct this behavior. The old fuzz tests are invalid and should be deleted. We can delete the old tests, without waiting on the draft Pr work to be picked back up.

@jasdel jasdel removed the needs-triage This issue or PR still needs to be triaged. label May 5, 2022
@aryan9600
Copy link
Author

@jasdel would it be possible to get an approximate time until there is a new release with the fuzzing tests removed? 😅

jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this issue May 11, 2022
@jasdel
internal/ini: Remove unused and stale fuzzing
3cdbdba 
Removes the fuzz testing files from the module, as they are invalid and
not used. PR draft aws#1291 looks
at adding fuzzing back in.

Fixes aws#1693
@jasdel jasdel mentioned this issue May 11, 2022
Closed
@jasdel
Copy link
Contributor

jasdel commented May 11, 2022

I've created PR #1699 that removes the bad fuzzing files from the internal/ini module. Separately PR #1291 still looks at providing fuzzing back in.

jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this issue May 16, 2022
@jasdel
internal/ini: Remove unused and stale fuzzing
2ef507c 
Removes the fuzz testing files from the module, as they are invalid and
not used. PR draft aws#1291 looks
at adding fuzzing back in.

Fixes aws#1693
@jasdel jasdel mentioned this issue May 16, 2022
Merged
jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this issue May 16, 2022
@jasdel
internal/ini: Remove unused and stale fuzzing
f0ba71c 
Removes the fuzz testing files from the module, as they are invalid and
not used. PR draft aws#1291 looks
at adding fuzzing back in.

Fixes aws#1693

add changelog
jasdel added a commit that referenced this issue May 16, 2022
@jasdel
internal/ini: Remove unused and stale fuzzing (#1710)
a34da05 
Removes the fuzz testing files from the module, as they are invalid and
not used. PR draft #1291 looks
at adding fuzzing back in.

Fixes #1693
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
2 participants
@jasdel @aryan9600