add SDK-specific feature tracking #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
force-pushed
the
feat-uafeaturemetrics
branch
from
03f7b36
to
a9b6916
Compare
wty-Bryant
approved these changes
Jun 17, 2024
Madrigal
approved these changes
Jun 17, 2024
| }, | ||
| "two": { | ||
| Features: []UserAgentFeature{ | ||
| UserAgentFeatureRetryModeAdaptive, // ensure stable order, and idempotent |
There was a problem hiding this comment.
[nit] not sure if I'd call it stable order since this maps to a set at the end, and we end up sorting the feature set
| type UserAgentFeature string | ||
|
|
||
| // Enumerates UserAgentFeature. | ||
| const ( |
There was a problem hiding this comment.
I double checked that these are correct (hate when I push a PR and then whoops typo)
lucix-aws
force-pushed
the
feat-uafeaturemetrics
branch
from
1294963
to
c8287fe
Compare
cPu1
added a commit
to cPu1/eksctl
that referenced
this pull request
Jun 25, 2024
The latest version of `aws-sdk-go-v2/service/eks` breaks unit tests. This [changelist](aws/aws-sdk-go-v2#2682) added SDK-specific feature tracking where all paginated operations now pass an additional argument (`addIsPaginatorUserAgent`) to add `UserAgentFeaturePaginator` to the user agent. The mocks, however, do not expect this variadic argument to be passed, resulting in failing assertions.
cPu1
added a commit
to cPu1/eksctl
that referenced
this pull request
Jun 25, 2024
The latest version of `aws-sdk-go-v2/service/eks` breaks unit tests. This [changelist](aws/aws-sdk-go-v2#2682) added SDK-specific feature tracking where all paginated operations now pass an additional argument (`addIsPaginatorUserAgent`) to add `UserAgentFeaturePaginator` to the user agent. The mocks, however, do not expect this variadic argument to be passed, resulting in failing assertions. Fixes eksctl-io#7845
cPu1
added a commit
to cPu1/eksctl
that referenced
this pull request
Jun 25, 2024
The latest version of `aws-sdk-go-v2/service/eks` breaks unit tests. This [changelist](aws/aws-sdk-go-v2#2682) added SDK-specific feature tracking where all paginated operations now pass an additional argument (`addIsPaginatorUserAgent`) to add `UserAgentFeaturePaginator` to the user agent. The mocks, however, do not expect this variadic argument to be passed, resulting in failing assertions. Fixes eksctl-io#7845
7 tasks
cPu1
added a commit
to cPu1/eksctl
that referenced
this pull request
Jun 25, 2024
The latest version of `aws-sdk-go-v2/service/eks` breaks unit tests. This [changelist](aws/aws-sdk-go-v2#2682) added SDK-specific feature tracking where all paginated operations now pass an additional argument (`addIsPaginatorUserAgent`) to add `UserAgentFeaturePaginator` to the user agent. The mocks, however, do not expect this variadic argument to be passed, resulting in failing assertions. Fixes eksctl-io#7845
cPu1
added a commit
to cPu1/eksctl
that referenced
this pull request
Jun 25, 2024
The latest version of `aws-sdk-go-v2/service/eks` breaks unit tests. This [changelist](aws/aws-sdk-go-v2#2682) added SDK-specific feature tracking where all paginated operations now pass an additional argument (`addIsPaginatorUserAgent`) to add `UserAgentFeaturePaginator` to the user agent. The mocks, however, do not expect this variadic argument to be passed, resulting in failing assertions. Fixes eksctl-io#7845
cPu1
added a commit
to cPu1/eksctl
that referenced
this pull request
Jun 26, 2024
The latest version of `aws-sdk-go-v2/service/eks` breaks unit tests. This [changelist](aws/aws-sdk-go-v2#2682) added SDK-specific feature tracking where all paginated operations now pass an additional argument (`addIsPaginatorUserAgent`) to add `UserAgentFeaturePaginator` to the user agent. The mocks, however, do not expect this variadic argument to be passed, resulting in failing assertions. Fixes eksctl-io#7845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracks usage of the following features in the user-agent string: