-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring SDK's code generation patterns #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
fixup/RefactorCodeGen
branch
from
May 2, 2019 21:02
90e0f35
to
8d3a114
Compare
Notes:
|
stealthycoin
approved these changes
May 23, 2019
Looks good. |
* Standardizing of the service model's ServiceID for the name of the service client's package. * Adds an operation `Response` type that is inaddition from the operation's `Output` parameters. This prevents collisions between SDK response metadata, marshaling methods, and modeled output parameters. **More information** * Refactor service client pacakge's client name to be named Client instead of the service's short name. Removes the stuttering of client package and type, (e.g. s3.Client) * Fix service endpoint lookups use the the service's modeled EndpointID instead of inconsistent service name. * Generate API operations into their own file instead of all operations and parameter types being generated into a single file. This improves readability of individual source files for documentation reference. Non-input/output types are still generated into a single file. * Removes aws/endpoints Service identifiers from endpoint list. These were not actually service identifiers, but EndpointsID. In addition the values modeled by the services were unstable, and could change causing breaking changes in the SDK's aws/endpoints package. The service client package's `EndpointsID` const should be used instead. * Move Paginate method from the initialized Request type into its own construct via the New<RequestType>Paginator function to create the request paginator. (e.g. req.Paginate becomes NewListObjectsPaginator(req))
jasdel
force-pushed
the
fixup/RefactorCodeGen
branch
from
May 24, 2019 21:58
0c14f89
to
dab2607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK's code generation pattern with several improvements to improve discoverability, and consistency in client naming.
Standardizing of the service model's ServiceID for the name of the
service client's package.
Adds an operation
Response
type that is in addition from theoperation's
Output
parameters. This prevents collisions between SDKresponse metadata, marshaling methods, and modeled output parameters.
Refactor service client package's client name to be named Client
instead of the service's short name. Removes the stuttering of client
package and type, (e.g. s3.S3 becomes s3.Client)
Fix service endpoint lookups use the the service's modeled EndpointID
instead of inconsistent service name.
Generate API operations into their own file instead of all operations
and parameter types being generated into a single file. This improves
readability of individual source files for documentation reference.
Non-input/output types are still generated into a single file. This change also fixes several occurrences of incorrectly generated API operation input/output type names.
Removes aws/endpoints Service identifiers from endpoint list. These
were not actually service identifiers, but EndpointsID. In addition the
values modeled by the services were unstable, and could change causing
breaking changes in the SDK's aws/endpoints package. The service
client package's
EndpointsID
const should be used instead.Move Paginate method from the initialized Request type into its own
construct via the NewPaginator function to create the
request paginator. (e.g. req.Paginate becomes NewListObjectsPaginator(req))
Fix #294 #282 #275