Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cloudwatchiface api change #874

Closed
wants to merge 1 commit into from
Closed

fix cloudwatchiface api change #874

wants to merge 1 commit into from

Conversation

h8liu
Copy link
Contributor

@h8liu h8liu commented May 26, 2019

No description provided.

@nelz9999
Copy link
Contributor

B/c of aws/aws-sdk-go-v2#298

(When I wrote this package, I didn't realize the v2 sdk was going to be in so much flux.)

nelz9999
nelz9999 suggested changes May 26, 2019
View reviewed changes
Copy link
Contributor

@nelz9999 nelz9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing... Probably need to update the unit test too.

@peterbourgon
Copy link
Member

This was fixed elsewhere.

@nsmith5
Copy link
Contributor

nsmith5 commented May 28, 2019

Not quite, this is a different issue. @peterbourgon I believe you're referencing #856. This issue is new as of 3 days ago.

@peterbourgon
Copy link
Member

Oh fuck, did they change this shit again?

@peterbourgon peterbourgon reopened this May 28, 2019
@peterbourgon
Copy link
Member 

# github.com/go-kit/kit/metrics/cloudwatch2 [github.com/go-kit/kit/metrics/cloudwatch2.test]
go/src/github.com/go-kit/kit/metrics/cloudwatch2/cloudwatch2_test.go:76:2: undefined: cloudwatchiface.CloudWatchAPI
FAIL	github.com/go-kit/kit/metrics/cloudwatch2 [build failed]

@peterbourgon
Copy link
Member

@h8liu Can you please update the test?

@peterbourgon
Copy link
Member

OK, now it was fixed elsewhere: #878.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelz9999 nelz9999 nelz9999 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h8liu @nelz9999 @peterbourgon @nsmith5