beta: feature/s3/transfermanager (S3 transfer manager v2) #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* recommit transfer manager v2 files * change pool to store slice pointer * add integ test for putobject * update go mod * minor changes for v0.1.0 * update tags * update tags * update integ test dependency version * change err var name * update go mod * change input/output type comment * minor change --------- Co-authored-by: Tianyi Wang <wty@amazon.com>
Madrigal
reviewed
Jan 28, 2025
wty-Bryant
approved these changes
Jan 28, 2025
lucix-aws
added a commit
that referenced
this pull request
Jan 29, 2025
)" This reverts commit 5c9d67c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modman.tomlmake+eachmoduleactions for the module, primarily to not run integration testsThe integration tests fail right now because of the recent S3 object integrity changes. So, integration tests in this PR should pass, since the module is being skipped.
Verified that
make releasedoes NOT tag the module.