Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node-http-handler): configure disableConcurrentStreams in NodeHttp2Handler #2553

Merged
merged 20 commits into from
Jul 9, 2021
Merged

feat(node-http-handler): configure disableConcurrentStreams in NodeHttp2Handler #2553

merged 20 commits into from
Jul 9, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 8, 2021 •
edited
Loading

Issue

Fixes: #2550

Description

Adds an option to disableConcurrentStreams in NodeHttp2Handler

Example:

const client = new H2HandlerClient({
  requestHandler: new NodeHttp2Handler({
    disableConcurrentStreams: true
  }),
});

Testing

CI is successful
Verified that TranscribeStreaming works in parallel in demo code https://github.com/trivikr/aws-parallel-transcribe-repro/pull/1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

trivikr added 17 commits July 7, 2021 18:51
@trivikr
chore: add disableSessionCache configuration
d846629
@trivikr
fix(node-http-handler): disable session cache if configured
3e7f681
@trivikr
fix: prevent creating session if request already aborted
0c95448
@trivikr
test: move h2 tests for error in new section
7f91d27
@trivikr
chore: replace test name with NodeHttp2Handler.name
79a3e8b
@trivikr
chore: move existing tests under without options section
175b21c
@trivikr
test: when disableSessionCache is set
af10a75
@trivikr
test: update connectionPool tests to check connect calls
234a65d
@trivikr
test: move sessionTimeout tests to its own section
5eba686
@trivikr
test: sessionTimeout with different disableSessionCache values
86906fa
@trivikr
test: add tests for requestTimeout
c70a88b
@trivikr
test: use arrow functions in server.mock
bf37020
@trivikr
test: fix request close on session when aborted
494c8ea 
Fixes: aws#487
@trivikr
chore: clear connections array on destroy
bf9f612
@trivikr
chore: rename 'connection' to 'session'
632334a
@trivikr
chore: use sessionCache and sessionList
9c4307d
@trivikr
chore: close session on response when disableSessionCache=true
05673bb
@trivikr trivikr requested a review from AllanZhengYP July 8, 2021 04:55
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@a51c2f4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2553   +/-   ##
=======================================
  Coverage        ?   60.31%           
=======================================
  Files           ?      513           
  Lines           ?    27377           
  Branches        ?     6582           
=======================================
  Hits            ?    16512           
  Misses          ?    10865           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51c2f4...2d1cade. Read the comment docs.

@trivikr trivikr mentioned this pull request Jul 8, 2021
Closed
@trivikr trivikr changed the title feat(node-http-handler): add option to disable session cache in NodeHttp2Handler feat(node-http-handler): configure disableConcurrentStreams in NodeHttp2Handler Jul 9, 2021
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 2d1cade
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AllanZhengYP
AllanZhengYP reviewed Jul 9, 2021
View reviewed changes
packages/node-http-handler/src/node-http2-handler.spec.ts
expect(connectSpy).toHaveBeenNthCalledWith(1, `${authorityPrefix}:${port}`);
expect(connectSpy).toHaveBeenNthCalledWith(2, `${authorityPrefix}:${port2}`);
mockH2Server2.close();
});
Copy link
Contributor

@AllanZhengYP AllanZhengYP Jul 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another unit test for "is many for same URL but concurrent stream is disabled"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concurrent stream disabled tests are in their own section on line 378.
The section starts with describe("disableConcurrentStreams", () => {

The specific test mentioned is many for same URL but concurrent stream is disabled is called is many if multiple requests are made on same URL, and is on line 402.

alexforsyth
alexforsyth reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I lack the context. i'll wait for @AllanZhengYP to approve

AllanZhengYP
AllanZhengYP approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@trivikr trivikr merged commit 9303bf7 into aws:main Jul 9, 2021
@trivikr trivikr deleted the handler-disable-session-cache branch July 9, 2021 16:25
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexforsyth alexforsyth alexforsyth left review comments

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to disable session cache in NodeHttp2Handler
5 participants
@trivikr @codecov-commenter @aws-sdk-js-automation @AllanZhengYP @alexforsyth