Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): populate variants in endpoints hashes #2962

Closed
wants to merge 24 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 1, 2021

Issue

Internal JS-2908

Follow-up to #2947
Cleaned up PR of #2957

Note: A new PR will be posted with final endpoints.json, once it's available. Expected date: 11/02.

Description

Populates variants in endpoints hashes.

Testing

N/A as variants are additive. The functional tests are successful.
The follow-up PRs will update unit tests in config-resolver, and affected middleware packages.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #2962 (6f20a32) into main (55f4e85) will not change coverage.
The diff coverage is n/a.

❗ Current head 6f20a32 differs from pull request most recent head 7f32fc8. Consider uploading reports for the commit 7f32fc8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2962   +/-   ##
=======================================
  Coverage   58.70%   58.70%           
=======================================
  Files         566      566           
  Lines       30315    30315           
  Branches     7460     7460           
=======================================
  Hits        17796    17796           
  Misses      12519    12519           
Impacted Files Coverage Δ
...lients/client-lex-runtime-service/src/endpoints.ts 100.00% <ø> (ø)
clients/client-mediastore-data/src/endpoints.ts 100.00% <ø> (ø)
clients/client-s3-control/src/endpoints.ts 100.00% <ø> (ø)
clients/client-sts/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-ec2/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-json-10/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-json/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-query/src/endpoints.ts 100.00% <ø> (ø)
...rivate/aws-protocoltests-restjson/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-restxml/src/endpoints.ts 100.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f4e85...7f32fc8. Read the comment docs.

@trivikr trivikr force-pushed the populate-variants-endpoint-hashes branch from 26abd2a to d468909 Compare November 1, 2021 17:08
@trivikr trivikr changed the base branch from config-fips-dualstack to main November 1, 2021 17:08
@trivikr trivikr marked this pull request as draft November 1, 2021 17:26
@trivikr trivikr force-pushed the populate-variants-endpoint-hashes branch 2 times, most recently from dad6a21 to 807389a Compare November 1, 2021 18:03
@trivikr trivikr force-pushed the populate-variants-endpoint-hashes branch from 807389a to 42e7158 Compare November 2, 2021 12:37
@trivikr
Copy link
Member Author

trivikr commented Nov 2, 2021

Superceded by #2974

@trivikr trivikr closed this Nov 2, 2021
@trivikr trivikr deleted the populate-variants-endpoint-hashes branch November 3, 2021 22:54
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants