Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore(clients): remove redundant endpoint configuration from PartitionHash #2965

Closed
wants to merge 8 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 1, 2021

Issue

Noticed while working on variants in #2962

Description

  • Removes redundant endpoint configuration from PartitionHash.
  • Populates signingRegion in PartitionHash instead.
  • Removes redundant configuration from RegionHash.
  • Updates getRegionInfo.

Testing

Unit testing


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #2965 (96f93e0) into main (abe4ed9) will not change coverage.
The diff coverage is n/a.

❗ Current head 96f93e0 differs from pull request most recent head 0987625. Consider uploading reports for the commit 0987625 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2965   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files         561      561           
  Lines       30272    30272           
  Branches     7452     7452           
=======================================
  Hits        17742    17742           
  Misses      12530    12530           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe4ed9...0987625. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Nov 2, 2021

Closing as clients can provide partition endpoint as region, an issue which was identified while working on this PR and fixed in #2969

@trivikr trivikr closed this Nov 2, 2021
@trivikr trivikr deleted the remove-endpoint-partitionHash branch November 2, 2021 12:30
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants