Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config-resolver): use real region in configuration #2986

Merged
merged 8 commits into from
Nov 4, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 4, 2021

Issue

Internal JS-2928

Description

If provided region is a pseudo region (FIPS):

  • the region in configuration is updated to real region.
  • useFipsEndpoint is set to true in configuration.

Testing

Unit testing


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from AllanZhengYP November 4, 2021 20:24
@codecov-commenter
Copy link

Codecov Report

Merging #2986 (22dedcf) into main (45365ac) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
+ Coverage   58.73%   58.75%   +0.01%     
==========================================
  Files         566      566              
  Lines       30341    30354      +13     
  Branches     7472     7479       +7     
==========================================
+ Hits        17821    17834      +13     
  Misses      12520    12520              
Impacted Files Coverage Δ
...rc/endpointsConfig/resolveCustomEndpointsConfig.ts 100.00% <ø> (ø)
...s/config-resolver/src/regionConfig/isFipsRegion.ts 100.00% <ø> (ø)
...lver/src/endpointsConfig/resolveEndpointsConfig.ts 100.00% <100.00%> (ø)
.../config-resolver/src/regionConfig/getRealRegion.ts 100.00% <100.00%> (ø)
...g-resolver/src/regionConfig/resolveRegionConfig.ts 100.00% <100.00%> (ø)
...es/config-resolver/src/regionInfo/getRegionInfo.ts 100.00% <100.00%> (ø)
...esolver/src/regionInfo/getResolvedSigningRegion.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45365ac...22dedcf. Read the comment docs.

@trivikr trivikr merged commit af5b00e into aws:main Nov 4, 2021
@trivikr trivikr deleted the use-real-region branch November 4, 2021 22:13
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants