Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): remove hostname key from endpoint hashes #2990

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 5, 2021

Issue

Follow-up to #2989

Description

Removes hostname key from hashes as the value is populated as a default variant:

Testing

Functional testing


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #2990 (f1ccfdc) into remove-deprecated-endpoints (d3f1abc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           remove-deprecated-endpoints    #2990   +/-   ##
============================================================
  Coverage                        58.76%   58.76%           
============================================================
  Files                              567      567           
  Lines                            30358    30358           
  Branches                          7481     7481           
============================================================
  Hits                             17839    17839           
  Misses                           12519    12519           
Impacted Files Coverage Δ
...lients/client-lex-runtime-service/src/endpoints.ts 100.00% <ø> (ø)
clients/client-mediastore-data/src/endpoints.ts 100.00% <ø> (ø)
clients/client-s3-control/src/endpoints.ts 100.00% <ø> (ø)
clients/client-sts/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-ec2/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-json-10/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-json/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-query/src/endpoints.ts 100.00% <ø> (ø)
...rivate/aws-protocoltests-restjson/src/endpoints.ts 100.00% <ø> (ø)
private/aws-protocoltests-restxml/src/endpoints.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f1abc...f1ccfdc. Read the comment docs.

@trivikr trivikr force-pushed the remove-hostname-endpoints-hashes branch from f1ccfdc to d6a7736 Compare November 5, 2021 17:35
@trivikr trivikr changed the base branch from remove-deprecated-endpoints to main November 5, 2021 17:35
@trivikr trivikr marked this pull request as ready for review November 5, 2021 17:35
@trivikr trivikr requested a review from AllanZhengYP November 5, 2021 17:35
@trivikr trivikr merged commit e45d8ee into aws:main Nov 5, 2021
@trivikr trivikr deleted the remove-hostname-endpoints-hashes branch November 5, 2021 18:41
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants