Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(endpoint): util-endpoints and middleware-endpoint for endpoints 2.0 #3932

Merged
merged 7 commits into from
Sep 13, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 12, 2022

Description

Split out from #3927

  • adds endpoints v2 utilities
  • remaining work is annotated with searchable tag TODO(endpointsv2)

@kuhe kuhe added the pr/needs-review This PR needs a review from a Member. label Sep 12, 2022
@kuhe kuhe requested a review from a team as a code owner September 12, 2022 20:25
@kuhe kuhe assigned kuhe and trivikr Sep 12, 2022
@kuhe kuhe force-pushed the endpoints-20-new-packages branch 2 times, most recently from 7846ecd to c1ec7c6 Compare September 12, 2022 21:26
Co-authored-by: AllanZhengYP <zheallan@amazon.com>
packages/types/src/auth.ts Outdated Show resolved Hide resolved
packages/types/src/auth.ts Outdated Show resolved Hide resolved
packages/types/src/credentials.ts Outdated Show resolved Hide resolved
/**
* Authentication schemes represent a way that the service will authenticate the customer’s identity.
*/
export interface AuthScheme {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is AuthScheme used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be used in updates to existing packages in the next PR, it can be seen in #3927

I wanted to update types with the new code in this PR instead of in multiple PRs, so as not to miss anything copying over from the original endpoints-20 branch.

packages/middleware-endpoint/package.json Outdated Show resolved Hide resolved
packages/middleware-endpoint/package.json Outdated Show resolved Hide resolved
packages/middleware-endpoint/package.json Outdated Show resolved Hide resolved
packages/middleware-endpoint/src/types.ts Outdated Show resolved Hide resolved
packages/middleware-endpoint/src/types.ts Show resolved Hide resolved
packages/middleware-endpoint/src/endpointMiddleware.ts Outdated Show resolved Hide resolved
kuhe and others added 6 commits September 13, 2022 11:42
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
@kuhe kuhe merged commit e81b7d0 into aws:main Sep 13, 2022
@kuhe kuhe deleted the endpoints-20-new-packages branch September 13, 2022 19:52
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr/needs-review This PR needs a review from a Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants