Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(endpoint): endpoints 2.0 existing package changes #3947

Merged
merged 14 commits into from
Sep 23, 2022
Merged

feat(endpoint): endpoints 2.0 existing package changes #3947

merged 14 commits into from
Sep 23, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 14, 2022 •
edited
Loading

PR 3 derived from #3927 split

previously:

This PR includes the changes to existing packages to support endpoints v2.

Manual testing code:
https://gist.github.com/kuhe/86ecde70c37ce2cf4afb07d1c561b2a8

Testing confirmed the following work both with and without the S3 endpoints 2.0 ruleset:

  • create, delete, get Object
  • list buckets
  • sign get request, sign put request, signed form post

feature test:

npx cucumber-js -t @s3 --format @cucumber/pretty-formatter

24 scenarios (24 passed)
131 steps (131 passed)

@kuhe kuhe force-pushed the endpoints-20-existing-package-updates branch from c7b4bac to 2d89568 Compare September 16, 2022 20:26
trivikr
trivikr reviewed Sep 16, 2022
View reviewed changes
packages/middleware-endpoint/src/adaptors/getEndpointFromConfig.ts Outdated Show resolved Hide resolved
packages/middleware-endpoint/src/adaptors/getEndpointFromConfig.ts Outdated Show resolved Hide resolved
packages/middleware-endpoint/src/adaptors/getEndpointFromConfig.ts Outdated Show resolved Hide resolved
packages/middleware-endpoint/src/adaptors/getEndpointFromConfig.ts Outdated Show resolved Hide resolved
packages/middleware-endpoint/src/endpointMiddleware.ts Outdated Show resolved Hide resolved
packages/middleware-endpoint/src/getEndpointPlugin.ts Outdated Show resolved Hide resolved
packages/middleware-endpoint/src/index.ts Outdated Show resolved Hide resolved
packages/middleware-endpoint/src/resolveEndpointConfig.ts Outdated Show resolved Hide resolved
packages/middleware-sdk-s3/src/configuration.ts Outdated Show resolved Hide resolved
packages/middleware-sdk-s3/src/configuration.ts Outdated Show resolved Hide resolved
@kuhe kuhe force-pushed the endpoints-20-existing-package-updates branch from 079c2f3 to 3dee79e Compare September 20, 2022 14:53
@kuhe kuhe marked this pull request as ready for review September 22, 2022 17:25
@kuhe kuhe requested a review from a team as a code owner September 22, 2022 17:25
@kuhe kuhe merged commit df99fc3 into aws:main Sep 23, 2022
@kuhe kuhe deleted the endpoints-20-existing-package-updates branch September 23, 2022 15:27
@stephank stephank mentioned this pull request Sep 26, 2022
Merged
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @trivikr