feat(smithy-client): parse datetime offsets #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
force-pushed
the
datetime-with-offsets
branch
3 times, most recently
from
c44c21b to
3c7a777
Compare
gosar
approved these changes
Jan 28, 2023
srchase
force-pushed
the
datetime-with-offsets
branch
from
3c7a777 to
319e456
Compare
srchase
force-pushed
the
datetime-with-offsets
branch
from
319e456 to
86ee3e2
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
Description
smithy-lang/smithy#1502 introduced protocol test coverage for datetimes with offsets for clients.
This PR adds a
parseRfc3339DateTimeWithOffsetfunction to handle positive and negative offsets.For now, the function is unused by any clients.
Testing
This was tested in conjunction with smithy-typescript changes to use the
parseRfc3339DateTimeWithOffsetfunction in place of the existingparseRfc3339DateTimefunction for clients.parseRfc3339DateTimeis retained for servers.yarn generate-clients && yarn test:protocolswas successfully run.The smithy-typescript changes will be paired with codegen changes to use the new parsing function within clients.
Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.