Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients parse datetime offsets #681

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jan 27, 2023

aws/aws-sdk-js-v3#4379 adds a new datetime parsing function, parseRfc3339DateTimeWithOffset.

This PR updates clients to use the added parsing function to gracefully handle offsets, normalizing them to zero offset.

Servers will continue to use the existing parseRfc3339DateTime function.

This PR should not be merged until aws/aws-sdk-js-v3#4379 has been reviewed and merged.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase merged commit f29d213 into smithy-lang:main Jan 30, 2023
@srchase srchase deleted the client-datetime-offsets branch January 30, 2023 23:30
srchase added a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants