Use serde elision index #4712
Use serde elision index #4712
Conversation
srchase
force-pushed
the
use-serde-elision-index
branch
from
5f80e2d to
6b81152
Compare
| if (shape.getId().getName().equals("DenseBooleanMap")) { | ||
| System.out.println("here"); | ||
| } |
| /** | ||
| * For handling expressions that may be unary function calls. | ||
| */ | ||
| public abstract class UnaryFunctionCall { |
There was a problem hiding this comment.
Why is this class abstract?
There was a problem hiding this comment.
Carry over from the original addition to smithy-typescript: https://github.com/awslabs/smithy-typescript/blob/main/smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/validation/UnaryFunctionCall.java. It doesn't need to be abstract.
There was a problem hiding this comment.
there might've been a linter warning when a class only has static methods and isn't abstract
srchase
force-pushed
the
use-serde-elision-index
branch
from
6b81152 to
99428ff
Compare
| @@ -55,16 +55,19 @@ final class JsonShapeSerVisitor extends DocumentShapeSerVisitor { | |||
|
|
|||
| private final BiFunction<MemberShape, String, String> memberNameStrategy; | |||
|
|
|||
| JsonShapeSerVisitor(GenerationContext context) { | |||
| JsonShapeSerVisitor(GenerationContext context, boolean serdeElisionEnabled) { | |||
There was a problem hiding this comment.
interface change is ok, right? if any external consumers upgrade, they change their calls at the same time?
| /** | ||
| * For handling expressions that may be unary function calls. | ||
| */ | ||
| class UnaryFunctionCall { |
There was a problem hiding this comment.
I think this repo and smithy-ts have different static analysis requirements. It might've needed to be abstract there when there were no instance level methods or properties. That check made sense to me.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Issue number, if available, prefixed with "#"
Description
This PR updates the Shape visitors and protocol generators to use the SerdeElision KnowledgeIndex that was converted in smithy-lang/smithy-typescript#759
It also adds the UnaryFunctionCall class that was originally added to smithy-typescript (and which is removed in smithy-lang/smithy-typescript#760).
Testing
Ran
yarn generate-clientsto assure there were no generated code differences.Additionally, ran
./gradlew clean buildfrom thecodegendirectory to assure that thejava.lang.OutOfMemoryError: Java heap spaceerrors were not thrown as described in #4692.Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.