Convert SerdeElision to KnowledgeIndex #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
force-pushed
the
serde-elision-knwledge-index
branch
from
5545a57 to
72331a5
Compare
srchase
force-pushed
the
serde-elision-knwledge-index
branch
from
72331a5 to
a24367f
Compare
...gen/src/main/java/software/amazon/smithy/typescript/codegen/knowledge/SerdeElisionIndex.java
Show resolved
Hide resolved
sugmanue
approved these changes
May 9, 2023
This was referenced May 9, 2023
kuhe
reviewed
May 9, 2023
| * incompatible shapes or traits that require additional handling, its serde | ||
| * function may be emitted. | ||
| */ | ||
| public class SerdeElisionIndex implements KnowledgeIndex { |
There was a problem hiding this comment.
should this say that this is only for JSON?
kuhe
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts SerdeElision validation class to a KnowledgeIndex.
The use of the KnowledgeIndex fixes out of memory errors resulting from the existing SerdeElision class, which creates an unbounded number of model instances.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.