-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clients): use migrated @smithy packages #4873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
force-pushed
the
migrate-packages
branch
7 times, most recently
from
June 26, 2023 22:33
c87b653
to
54549b5
Compare
trivikr
approved these changes
Jun 28, 2023
trivikr
changed the title
Update codegen to use migrated @smithy packages
feat(clients): use migrated @smithy packages
Jun 28, 2023
srchase
force-pushed
the
migrate-packages
branch
4 times, most recently
from
June 28, 2023 18:30
36cf994
to
d246243
Compare
srchase
force-pushed
the
migrate-packages
branch
from
June 28, 2023 20:18
d246243
to
f8f22da
Compare
trivikr
approved these changes
Jun 28, 2023
trentm
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Jun 29, 2023
In aws/aws-sdk-js-v3#4873 aws-sdk v3 moved @aws-sdk/smithy-client to @smithy/smithy-client. This will now instrument either package name. Fixes: #3454
m-radzikowski
added a commit
to m-radzikowski/aws-sdk-client-mock
that referenced
this pull request
Jul 1, 2023
AWS SDK v3.363.0 migrated from @aws-sdk/types to @smithy/types. See: - https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.363.0 - aws/aws-sdk-js-v3#4873 - #168
trentm
added a commit
to elastic/apm-agent-nodejs
that referenced
this pull request
Jul 4, 2023
…se (#3455) In aws/aws-sdk-js-v3#4873 aws-sdk v3 moved @aws-sdk/smithy-client to @smithy/smithy-client. This will now instrument either package name. Fixes: #3454
3 tasks
3 tasks
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
Description
This PR updates packages, codegen and applies codegen to clients to use @smithy packages.
Relies on codegen changes in smithy-lang/smithy-typescript#791
Testing
How was this change tested?
Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.