Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @aws-sdk/client-s3 instrumentation was broken with 3.363.0 release #3455

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Jun 29, 2023

In aws/aws-sdk-js-v3#4873 aws-sdk v3 moved
@aws-sdk/smithy-client to @smithy/smithy-client. This will now
instrument either package name.

Fixes: #3454

In aws/aws-sdk-js-v3#4873 aws-sdk v3 moved
@aws-sdk/smithy-client to @smithy/smithy-client. This will now
instrument either package name.

Fixes: #3454
@trentm trentm requested a review from david-luna June 29, 2023 23:47
@trentm trentm self-assigned this Jun 29, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jun 29, 2023
Copy link
Member Author

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav @aws-sdk/client-s3

@trentm trentm merged commit fe71aae into main Jul 4, 2023
@trentm trentm deleted the trentm/fix-client-s3-smithy branch July 4, 2023 21:19
@trentm trentm mentioned this pull request Jul 5, 2023
1 task
fpm-peter pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
…se (elastic#3455)

In aws/aws-sdk-js-v3#4873 aws-sdk v3 moved
@aws-sdk/smithy-client to @smithy/smithy-client. This will now
instrument either package name.

Fixes: elastic#3454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aws-sdk/client-s3 test failures with recent 3.363.0 version
2 participants