Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add IAM endpoint for us-isob-* #3056

Merged
merged 2 commits into from
Jan 17, 2020
Merged

fix: add IAM endpoint for us-isob-* #3056

merged 2 commits into from
Jan 17, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 17, 2020

Confirmed that region is set for IAM endpoint using AWS REPL

aws-sdk> let client = new AWS.IAM({ "region": "us-isob-east-1" });

aws-sdk> let req = client.listRoles();

aws-sdk> req.httpRequest.region
'us-isob-east-1'
Checklist
  • npm run test passes
  • changelog is added, npm run add-change

@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #3056 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3056   +/-   ##
=======================================
  Coverage   97.05%   97.05%           
=======================================
  Files         330      330           
  Lines        9521     9521           
  Branches     1747     1747           
=======================================
  Hits         9241     9241           
  Misses        280      280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f7779...d926e60. Read the comment docs.

@trivikr trivikr merged commit da1090c into aws:master Jan 17, 2020
@trivikr trivikr deleted the us-isob-endpoint branch January 17, 2020 17:25
@trivikr trivikr mentioned this pull request Jan 24, 2020
2 tasks
@lock
Copy link

lock bot commented Jan 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants