Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add endpoint for us-isob-* #3064

Merged
merged 2 commits into from
Jan 24, 2020
Merged

fix: add endpoint for us-isob-* #3064

merged 2 commits into from
Jan 24, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 24, 2020

add endpoint for us-isob-*
An update to IAM endpoint as done in #3056

Confirmed that region is set for IAM endpoint using AWS REPL

aws-sdk> let client = new AWS.S3({ "region": "us-isob-east-1" });

aws-sdk> let req = client.listBuckets();

aws-sdk> req.httpRequest.region
'us-isob-east-1'
Checklist
  • npm run test passes
  • changelog is added, npm run add-change

@codecov-io
Copy link

codecov-io commented Jan 24, 2020

Codecov Report

Merging #3064 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3064   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files         330      330           
  Lines        9528     9528           
  Branches     1749     1749           
=======================================
  Hits         9248     9248           
  Misses        280      280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e558d...3ebd894. Read the comment docs.

@trivikr trivikr merged commit 29f68f1 into aws:master Jan 24, 2020
@trivikr trivikr deleted the us-isob-endpoint-2 branch January 24, 2020 00:55
@trivikr trivikr mentioned this pull request Jan 24, 2020
2 tasks
@lock
Copy link

lock bot commented Jan 31, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants