chore: refactor test assertions to be more idiomatic #5963
+34
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
changed the title
alexandear
force-pushed
the
chore/refactor-test-asserts
branch
2 times, most recently
from
7b17027
to
7ef9f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR refactors test assertions to be more idiomatic:
require.NotNil(t, err)withrequire.Error(t, err).require.Equal(t, nil, err)withrequire.NoError(t, err).require.Nil(t, err)withrequire.NoError(t, err).Additionally, the PR enables
testifylintto suggest these fixes in the future.testifylintis present in golangci-lint starting from versionv1.55. Therefore, this PR updates the golangci-lint version to the latestv1.60in theci.ymland disables a few lint issues not related to the topic. These issues will be fixed later.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.