Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor test assertions to be more idiomatic #5963

Open
wants to merge 1 commit into
base: mainline
Choose a base branch
from
+34 −22

chore: refactor test assertions to be more idiomatic

7b17027
Select commit
Loading
Failed to load commit list.
Open

chore: refactor test assertions to be more idiomatic #5963

chore: refactor test assertions to be more idiomatic
7b17027
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Nov 29, 2024 in 4s

2 potential rules

‼️ Action Required ‼️

The configuration uses the deprecated merge_method attribute of the queue action in one or more pull_request_rules. It must now be used under the queue_rules configuration.
This option will be removed on January 31st, 2025.
For more information: https://docs.mergify.com/configuration/file-format/#queue-rules

‼️ Action Required ‼️

The configuration uses the deprecated commit_message_template attribute of the queue action in one or more pull_request_rules. It must now be used under the queue_rules configuration.
This option will be removed on January 31st, 2025.
For more information: https://docs.mergify.com/configuration/file-format/#queue-rules

Rule: Merge for developers (queue)

  • #approved-reviews-by>=2
  • approved-reviews-by=@aws/aws-ecs-devx
  • status-success=build (compile-darwin)
  • status-success=build (compile-linux)
  • status-success=build (compile-windows)
  • status-success=license
  • status-success=staticcheck
  • status-success=test
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build (compile-darwin)
        • check-skipped = build (compile-darwin)
        • check-success = build (compile-darwin)
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build (compile-linux)
        • check-skipped = build (compile-linux)
        • check-success = build (compile-linux)
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build (compile-windows)
        • check-skipped = build (compile-windows)
        • check-success = build (compile-windows)
      • any of: [🛡 GitHub branch protection]
        • check-neutral = staticcheck
        • check-skipped = staticcheck
        • check-success = staticcheck
      • any of: [🛡 GitHub branch protection]
        • check-neutral = test
        • check-skipped = test
        • check-success = test
      • any of: [🛡 GitHub branch protection]
        • check-neutral = license
        • check-skipped = license
        • check-success = license
      • any of: [🛡 GitHub branch protection]
        • check-neutral = conventional-commits
        • check-skipped = conventional-commits
        • check-success = conventional-commits
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • -approved-reviews-by~=author
  • -closed
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • -label~=(WIP|do-not-merge)
  • -merged
  • -title~=(WIP|wip)
  • author!=dependabot[bot]
  • base~=(mainline|rename-commands)
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Rule: Ask Japanese docs reviews (request_reviews)

  • files~=\.ja.md$
  • -closed
💖  Mergify is proud to provide this service for free to open source projects.

🚀  You can help us by becoming a sponsor!

2 not applicable rules

Rule: Merge for bots (queue)

  • #approved-reviews-by>=1
  • author=dependabot[bot]
  • status-success=build (compile-darwin)
  • status-success=build (compile-linux)
  • status-success=build (compile-windows)
  • status-success=license
  • status-success=staticcheck
  • status-success=test
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build (compile-darwin)
        • check-skipped = build (compile-darwin)
        • check-success = build (compile-darwin)
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build (compile-linux)
        • check-skipped = build (compile-linux)
        • check-success = build (compile-linux)
      • any of: [🛡 GitHub branch protection]
        • check-neutral = build (compile-windows)
        • check-skipped = build (compile-windows)
        • check-success = build (compile-windows)
      • any of: [🛡 GitHub branch protection]
        • check-neutral = staticcheck
        • check-skipped = staticcheck
        • check-success = staticcheck
      • any of: [🛡 GitHub branch protection]
        • check-neutral = test
        • check-skipped = test
        • check-success = test
      • any of: [🛡 GitHub branch protection]
        • check-neutral = license
        • check-skipped = license
        • check-success = license
      • any of: [🛡 GitHub branch protection]
        • check-neutral = conventional-commits
        • check-skipped = conventional-commits
        • check-success = conventional-commits
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0
  • -closed
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • -label~=(WIP|do-not-merge)
  • -merged
  • -title~=(WIP|wip)
  • base=mainline
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Rule: Merge for bots (review)

  • #approved-reviews-by>=1
  • author=dependabot[bot]
  • status-success=build (compile-darwin)
  • status-success=build (compile-linux)
  • status-success=build (compile-windows)
  • status-success=license
  • status-success=staticcheck
  • status-success=test
  • #changes-requested-reviews-by=0
  • -closed
  • -label~=(WIP|do-not-merge)
  • -merged
  • -title~=(WIP|wip)
  • base=mainline
Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

View more details on Mergify