Remove dependencies for EKS Distro version upgrade step #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/M
abhay-krishna
changed the title
|
/lgtm |
|
/lgtm |
|
@abhay-krishna: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abhay-krishna
added a commit
to abhay-krishna/eks-anywhere-build-tooling
that referenced
this pull request
Jun 25, 2024
abhay-krishna
added a commit
that referenced
this pull request
Jun 25, 2024
* Automate Bottlerocket release version updates (#2959) * Automate Cilium and EKS Distro releases upgrade (#2973) * Define Go version files for etcdadm bootstrap provider and controller (#2977) * Extract only the Go binary from GitHub release tarball (#2978) * Allow different tags for required images in Helm charts (#2983) * Remove rolesanywhere-credential-helper project from upgrade buildspec (#2987) * Attempt to apply patches and generate checksums/attribution if successful (#2992) * Remove newlines from kubeVersion field (#3002) * Fix checksums and attribution generation during upgrade (#3009) * Fix condition for patches warning comment on upgrade PRs (#3038) * Fix attribution and checksum generation for successful patch application (#3060) * Fix Bottlerocket host container metadata files (#3075) * Support upgrading release-branched projects (#3066) * Filter out pre-release tags in upgrader flow (#3089) * Handle cases where GitHub release does not exist for tag (#3116) * Fix Go mod location for cluster-autoscaler (#3127) * Allow upgrading projects tracked with commits (#3136) * Fix pre-release detection logic when fetching latest GitHub revision (#3140) * Fix cert-manager GitHub release tarball name (#3142) * Handle patches application for release-branched projects (#3150) * Allow projects to selectively upgrade to pre-release tags (#3164) * Remove dependencies for EKS Distro version upgrade step (#3166) * Refactor latest release logic for EKS Distro upgrades (#3174) * Fix the issue of patch repo in upgrade cmd (#3220) * Make image-builder upgrade flow non-release-branched (#3234) * Use latest release branch by default if not defined, fall back to Github file for Go versions (#3244) * Avoid printing directory name for Make command (#3249) * Use go.mod file to retrieve cert-manager Go version (#3273) * Exclude GitHub Helm chart release tags (#3320) * Allow project upgrades on release branch (#3275) * Use Go 1.22 to build version tracker binary (#3081) --------- Co-authored-by: Xu Deng <xudeng@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EKS Distro upgrade step is added as a "final stage" to the upgrader buildspec because it isn't a project in the
projectsfolder so doesn't get added along with other projects in the loop. The generate script usually adds all the previous stages as dependencies to this final stage, but in this case, there is no actual dependency, so we are removing the dependencies from the buildspec.This also avoids the problem of the EKS Distro upgrade step being skipped (unnecessarily) when any of the other project upgrades fail.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.