Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude GitHub Helm chart release tags #3320

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

abhay-krishna
Copy link
Member

@abhay-krishna abhay-krishna commented Jun 12, 2024

When determining the latest GitHub release, we need to filter out GitHub releases corresponding to Helm charts. This check is not exhaustive but works for the projects we currently maintain.

Before

$ RELEASE_BRANCH=1-30 bin/version-tracker display --project kubernetes/cloud-provider-vsphere
ORGANIZATION  REPOSITORY              CURRENT VERSION  LATEST VERSION            
kubernetes    cloud-provider-vsphere  v1.30.0          vsphere-cpi-chart-1.30.1

After

$ RELEASE_BRANCH=1-30 bin/version-tracker display --project kubernetes/cloud-provider-vsphere
ORGANIZATION  REPOSITORY              CURRENT VERSION  LATEST VERSION  
kubernetes    cloud-provider-vsphere  v1.30.0          v1.30.1 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2024
@rahulbabu95
Copy link
Member

/lgtm

@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 01be548 into aws:main Jun 12, 2024
1 check passed
@abhay-krishna abhay-krishna deleted the exclude-helm-git-tags branch June 12, 2024 22:25
abhay-krishna added a commit to abhay-krishna/eks-anywhere-build-tooling that referenced this pull request Jun 25, 2024
abhay-krishna added a commit that referenced this pull request Jun 25, 2024
* Automate Bottlerocket release version updates (#2959)

* Automate Cilium and EKS Distro releases upgrade (#2973)

* Define Go version files for etcdadm bootstrap provider and controller (#2977)

* Extract only the Go binary from GitHub release tarball (#2978)

* Allow different tags for required images in Helm charts (#2983)

* Remove rolesanywhere-credential-helper project from upgrade buildspec (#2987)

* Attempt to apply patches and generate checksums/attribution if successful (#2992)

* Remove newlines from kubeVersion field (#3002)

* Fix checksums and attribution generation during upgrade (#3009)

* Fix condition for patches warning comment on upgrade PRs (#3038)

* Fix attribution and checksum generation for successful patch application (#3060)

* Fix Bottlerocket host container metadata files (#3075)

* Support upgrading release-branched projects (#3066)

* Filter out pre-release tags in upgrader flow (#3089)

* Handle cases where GitHub release does not exist for tag (#3116)

* Fix Go mod location for cluster-autoscaler (#3127)

* Allow upgrading projects tracked with commits (#3136)

* Fix pre-release detection logic when fetching latest GitHub revision (#3140)

* Fix cert-manager GitHub release tarball name (#3142)

* Handle patches application for release-branched projects (#3150)

* Allow projects to selectively upgrade to pre-release tags (#3164)

* Remove dependencies for EKS Distro version upgrade step (#3166)

* Refactor latest release logic for EKS Distro upgrades (#3174)

* Fix the issue of patch repo in upgrade cmd (#3220)

* Make image-builder upgrade flow non-release-branched (#3234)

* Use latest release branch by default if not defined, fall back to Github file for Go versions (#3244)

* Avoid printing directory name for Make command (#3249)

* Use go.mod file to retrieve cert-manager Go version (#3273)

* Exclude GitHub Helm chart release tags (#3320)

* Allow project upgrades on release branch (#3275)

* Use Go 1.22 to build version tracker binary (#3081)

---------

Co-authored-by: Xu Deng <xudeng@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants