Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.19] Disable ETCD Learner Mode #7719

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #7669

/assign abhay-krishna

jonathanmeier5 and others added 2 commits February 27, 2024 00:47
ETCD Learner Mode went to Beta in k8s 1.29 and is now default enabled.

When a new stacked etcd instance comes up, it joins the cluster in learner mode.

The API Server cannot perform rpc calls against its etcd instance, and fails to come online.

In theory the etcd instance should be promoted to a full member and this issue should
be resolved, but for some reason this is not happening.

While we investigate a root cause, we are disabling this new feature flag explicitly.
@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 27, 2024
@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-0.19@879b80f). Click here to learn what that means.

Files Patch % Lines
pkg/providers/snow/apibuilder.go 33.33% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.19    #7719   +/-   ##
===============================================
  Coverage                ?   73.61%           
===============================================
  Files                   ?      588           
  Lines                   ?    37177           
  Branches                ?        0           
===============================================
  Hits                    ?    27369           
  Misses                  ?     8016           
  Partials                ?     1792           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna abhay-krishna merged commit 97053a9 into aws:release-0.19 Feb 27, 2024
9 of 11 checks passed
mitalipaygude added a commit to mitalipaygude/eks-anywhere-1 that referenced this pull request Feb 27, 2024
mitalipaygude added a commit that referenced this pull request Feb 27, 2024
eks-distro-pr-bot pushed a commit to eks-distro-pr-bot/eks-anywhere that referenced this pull request Feb 27, 2024
eks-distro-bot pushed a commit that referenced this pull request Feb 27, 2024
This reverts commit 97053a9.

Co-authored-by: Mitali Paygude <mitalipaygude@gmail.com>
abhinavmpandey08 added a commit that referenced this pull request Feb 28, 2024
eks-distro-bot pushed a commit that referenced this pull request Feb 28, 2024
abhinavmpandey08 added a commit that referenced this pull request Mar 1, 2024
abhinavmpandey08 added a commit that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants