-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable ETCD Learner Mode #7669
Disable ETCD Learner Mode #7669
Conversation
Skipping CI for Draft Pull Request. |
7b59ee5
to
e914cd1
Compare
e914cd1
to
9ebb28f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7669 +/- ##
==========================================
+ Coverage 73.48% 73.60% +0.12%
==========================================
Files 579 588 +9
Lines 36357 37157 +800
==========================================
+ Hits 26718 27351 +633
- Misses 7875 8014 +139
- Partials 1764 1792 +28 ☔ View full report in Codecov by Sentry. |
239f69d
to
d10e068
Compare
pkg/providers/cloudstack/testdata/expected_results_availability_zones_cp.yaml
Outdated
Show resolved
Hide resolved
d10e068
to
e4ab7ba
Compare
ETCD Learner Mode went to Beta in k8s 1.29 and is now default enabled. When a new stacked etcd instance comes up, it joins the cluster in learner mode. The API Server cannot perform rpc calls against its etcd instance, and fails to come online. In theory the etcd instance should be promoted to a full member and this issue should be resolved, but for some reason this is not happening. While we investigate a root cause, we are disabling this new feature flag explicitly.
e4ab7ba
to
87f158b
Compare
fdceb1e
to
f44c9e8
Compare
/cherrypick release-0.19 |
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abhay-krishna: new pull request created: #7719 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ETCD Learner Mode went to Beta in k8s 1.29 and is now default enabled (see here, here).
When a new stacked etcd instance comes up, it joins the cluster in learner mode.
The API Server cannot perform rpc calls against its etcd instance, and fails to come online.
In theory the etcd instance should be promoted to a full member as done in kubeadm here.
This is not happening because our bottlerocket bootstrap container is not allowing etcd phase to complete.
We are disabling this feature for 0.19 and will likely enable it for 0.20 when we also incorporate new CAPI work that allows feature gates to be mutable.
The feature gate will likely go GA in upstream 1.31.
Issue #, if available:
This was causing failures on *129StackedEtcdUpgrade end to end tests.
Testing (if applicable):
Ran TestVSphereKubernetes128BottlerocketTo129StackedEtcdUpgrade with a custom built controller image that set this EtcdLearnerEnabled feature flag to false.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.