Disable ETCD Learner Mode

[jonathanmeier5]

ETCD Learner Mode went to Beta in k8s 1.29 and is now default enabled (see here, here).

When a new stacked etcd instance comes up, it joins the cluster in learner mode.

The API Server cannot perform rpc calls against its etcd instance, and fails to come online.

In theory the etcd instance should be promoted to a full member as done in kubeadm here.

This is not happening because our bottlerocket bootstrap container is not allowing etcd phase to complete.

We are disabling this feature for 0.19 and will likely enable it for 0.20 when we also incorporate new CAPI work that allows feature gates to be mutable.

The feature gate will likely go GA in upstream 1.31.

Issue #, if available:
This was causing failures on *129StackedEtcdUpgrade end to end tests.

Testing (if applicable):
Ran TestVSphereKubernetes128BottlerocketTo129StackedEtcdUpgrade with a custom built controller image that set this EtcdLearnerEnabled feature flag to false.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[eks-distro-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 73.60%. Comparing base (4583834) to head (f44c9e8).
Report is 139 commits behind head on main.

Files	Patch %	Lines
pkg/providers/snow/apibuilder.go	33.33%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7669      +/-   ##
==========================================
+ Coverage   73.48%   73.60%   +0.12%     
==========================================
  Files         579      588       +9     
  Lines       36357    37157     +800     
==========================================
+ Hits        26718    27351     +633     
- Misses       7875     8014     +139     
- Partials     1764     1792      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[abhay-krishna]

/cherrypick release-0.19

[eks-distro-pr-bot]

@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abhay-krishna]

/lgtm

[abhay-krishna]

/approve

[eks-distro-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abhay-krishna]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eks-distro-pr-bot]

@abhay-krishna: new pull request created: #7719

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.