Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BR 128 to 129 Stacked ETCD Upgrade #7722

Conversation

jonathanmeier5
Copy link
Member

Enables e2e test fixed by #7669

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (4583834) to head (03ced19).
Report is 140 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7722      +/-   ##
==========================================
+ Coverage   73.48%   73.60%   +0.12%     
==========================================
  Files         579      588       +9     
  Lines       36357    37157     +800     
==========================================
+ Hits        26718    27351     +633     
- Misses       7875     8014     +139     
- Partials     1764     1792      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathanmeier5
Copy link
Member Author

/approved

@jonathanmeier5
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathanmeier5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jonathanmeier5 jonathanmeier5 merged commit cb482f6 into aws:main Feb 27, 2024
9 of 10 checks passed
@jonathanmeier5
Copy link
Member Author

/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@jonathanmeier5: #7722 failed to apply on top of branch "release-0.19":

Applying: Enable BR 128 to 129 Stacked ETCD Upgrade
Using index info to reconstruct a base tree...
M	test/e2e/SKIPPED_TESTS.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/SKIPPED_TESTS.yaml
CONFLICT (content): Merge conflict in test/e2e/SKIPPED_TESTS.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Enable BR 128 to 129 Stacked ETCD Upgrade
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jonathanmeier5 added a commit to jonathanmeier5/eks-anywhere that referenced this pull request Feb 27, 2024
jonathanmeier5 added a commit to jonathanmeier5/eks-anywhere that referenced this pull request Feb 27, 2024
jonathanmeier5 added a commit to jonathanmeier5/eks-anywhere that referenced this pull request Feb 27, 2024
sp1999 pushed a commit to sp1999/eks-anywhere that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants