Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ipython and ipykernel dependency versions #207

Merged
merged 5 commits into from
Oct 12, 2021
Merged

Conversation

michaelnchin
Copy link
Member

Issue #, if available: N/A

Description of changes:

  • Add additional instructions in README to manully pin ipython==7.16.1 and ipykernel==5.3.4. This resolves an issue with notebooks crashing on Python versions >= 3.8, where installing notebook would pick up an incompatible newer version of ipython.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

krlawrence
krlawrence previously approved these changes Oct 11, 2021
Copy link
Contributor

@krlawrence krlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelnchin michaelnchin merged commit e7a8cef into main Oct 12, 2021
@michaelnchin michaelnchin deleted the 3.8-dep-fix branch October 12, 2021 17:51
michaelnchin added a commit that referenced this pull request Oct 20, 2021
* Pin ipython and ipykernel dependency versions (#207)

* Pin ipython and ipykernel dependency versions

* Update Changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Apply nest_asyncio for Gremlin client requests, Update dependencies and install docs

* Switch to python script for starting jupyter

* Allow specifying notebooks directory on startup

* Pinning nbconvert version to resolve ipython-contrib/jupyter_contrib_nbextensions#1529

* Fix OC query smart indent bug

* Fix failure to overwrite notebook.json

Co-authored-by: Michael Chin <chnmch@amazon.com>
michaelnchin added a commit that referenced this pull request Oct 21, 2021
* Remove dependency on Tornado and use the Gremlin 3.5.x replacement

* HashableDict is part of Gremlin 3.5 no longer need to backport

* Merge GREMLIN35-v2 into GREMLIN35 (#208)

* Pin ipython and ipykernel dependency versions (#207)

* Pin ipython and ipykernel dependency versions

* Update Changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Apply nest_asyncio for Gremlin client requests, Update dependencies and install docs

* Switch to python script for starting jupyter

* Allow specifying notebooks directory on startup

* Pinning nbconvert version to resolve ipython-contrib/jupyter_contrib_nbextensions#1529

* Fix OC query smart indent bug

* Fix failure to overwrite notebook.json

Co-authored-by: Michael Chin <chnmch@amazon.com>

* ChangeLog.md

Co-authored-by: Kelvin Lawrence <gfxman@yahoo.com>
Co-authored-by: Michael Chin <chnmch@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants