Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gremlin-Python 3.5 and Jupyter Notebook 6.x #209

Merged
merged 5 commits into from
Oct 21, 2021
Merged

Conversation

michaelnchin
Copy link
Member

Issue #, if available: #68, #160, GHSA-c7vm-f5p4-8fqh

Description of changes:

  • Upgraded to gremlinpython>=3.5.1, and switch from Tornado httpclient to using AIOHTTP for Gremlin websocket requests
  • Upgraded to notebook>=6.1.5 to resolve a security issue
  • Added Jupyter Notebook startup script with required KernelManager launch option; also includes patch for CodeMirror Cypher query formatting issues

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

krlawrence and others added 3 commits October 12, 2021 10:45
* Pin ipython and ipykernel dependency versions (#207)

* Pin ipython and ipykernel dependency versions

* Update Changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Apply nest_asyncio for Gremlin client requests, Update dependencies and install docs

* Switch to python script for starting jupyter

* Allow specifying notebooks directory on startup

* Pinning nbconvert version to resolve ipython-contrib/jupyter_contrib_nbextensions#1529

* Fix OC query smart indent bug

* Fix failure to overwrite notebook.json

Co-authored-by: Michael Chin <chnmch@amazon.com>
@michaelnchin michaelnchin requested a review from bechbd October 21, 2021 16:09
@michaelnchin michaelnchin merged commit 371efdf into main Oct 21, 2021
@michaelnchin michaelnchin deleted the GREMLIN35 branch October 25, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants