fix(jsii): annotation '@internal' causes missing type declarations downstream #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop setting 'stipInternal: true' in tsconfig.json files, as this makes it impossible to mark intentionally unexported types as @internal without causing downstream compilation failures due to missing type declarations.
RomainMuller
added
effort/small
nija-at
approved these changes
Oct 23, 2020
RomainMuller
changed the title
I hesitated... changed it up :) |
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
nija-at
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
This was referenced Oct 23, 2020
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Oct 23, 2020
…" (#11070) This reverts commit 0537598. This change requires aws/jsii#2172 to be merged and a jsii upgrade as the usage of `@internal` for `HttpPrivateIntegration` and `VpcLinkConfigurationOptions` is causing downstream compilation failures currently. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb
pushed a commit
to cdklabs/decdk
that referenced
this pull request
Jan 18, 2022
…1)" (#11070) This reverts commit fc74e037c5be4e364d249ab5cad6998490880afa. This change requires aws/jsii#2172 to be merged and a jsii upgrade as the usage of `@internal` for `HttpPrivateIntegration` and `VpcLinkConfigurationOptions` is causing downstream compilation failures currently. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop setting
stipInternal: trueintsconfig.jsonfiles, as this makes it impossibleto mark intentionally unexported types as
@internalwithout causing downstreamcompilation failures due to missing type declarations.
Fixes #1947
Related to #1830
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.