Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsii): annotation '@internal' causes missing type declarations downstream #2172

Merged
merged 2 commits into from
Oct 23, 2020
Merged

fix(jsii): annotation '@internal' causes missing type declarations downstream #2172

merged 2 commits into from
Oct 23, 2020

Commits on Oct 23, 2020

  1. feat(jsii): turn off 'stripInternal' in generated tsconfig.json 

    Stop setting 'stipInternal: true' in tsconfig.json files, as this makes it impossible
to mark intentionally unexported types as @internal without causing downstream
compilation failures due to missing type declarations.
    @RomainMuller
    RomainMuller committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    84e6d67 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rmuller/no-erase-internals

    @mergify
    mergify[bot] committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    e322c66 View commit details
    Browse the repository at this point in the history