chore: cleanup deprovisioning types #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4885735774
💛 - Coveralls |
ellistarn
reviewed
Apr 12, 2023
ellistarn
reviewed
Apr 12, 2023
|
Can we define a protocol for manual testing for any changes to the core deprovisioning logic? Further, can you elaborate in the description about why this change is being made? |
|
Overall I'm fine with this change, but I'm nervous given the recent regressions to deprovisioning. It's not an option to stop making changes, but we need to figure out what mechanisms we can add to increase our confidence in making changes. |
* Revert "Revert machine migration changes (kubernetes-sigs#176) (kubernetes-sigs#241)" This reverts commit 9973eac. * Change owner reference to blockOwnerDeletion * Remove string logging for machine launch * Removing FailedInit since machine statusCondition captures it * Updated eventing on machines
jackfrancis
reviewed
May 3, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #280
Description
Removes an the old
actiontype in the deprovisioning controller since the type of action can be inferred from the len(candidates) to replace or len(replacements).How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.