Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Grant update permissions to nodes #6471

Closed

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This fixes a permission issue that was causing E2E testing to fail due to Karpenter not having UPDATE permission on nodes with the change added in kubernetes-sigs/karpenter#1336

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner July 9, 2024 05:32
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d6bc7a2
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/668ccb8384ff9500080db6f4

@jonathan-innis jonathan-innis enabled auto-merge (squash) July 9, 2024 05:33
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-d6bc7a29fc7156b659eeb3ae249c06b3f4e0a372.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-d6bc7a29fc7156b659eeb3ae249c06b3f4e0a372" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9851551387

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.023%

Totals Coverage Status
Change from base Build 9848062806: 0.0%
Covered Lines: 5967
Relevant Lines: 7551

💛 - Coveralls

@jonathan-innis
Copy link
Contributor Author

Closing in favor of #6469

auto-merge was automatically disabled July 9, 2024 08:28

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants